SchSeba / sriov-cni-1

63%

master: 46%

LAST BUILD ON BRANCH support_mac_reset_release_4.21

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• bump_netlink_4.14
• bump_netlink_4.15
• bump_netlink_4.16
• fips_support
• fips_support_4.15
• fips_support_4.16
• fips_support_4.16_1
• fix_cache_4.16
• merge-bot-master
• mtu_revert_4.18
• snyk-master
• support_mac_reset_release_4.21
• support_rhel10
• sync-2023-06-20
• sync-2023-07-11
• sync-2024-03-20
• sync-2024-07-17
• sync_26_10_25
• sync_master_28_07_22
• test

Build # 26096743799

Build Type

push

github

Committed by SchSeba

Commit Message

fix: gate effective MAC restore on cached state instead of user config in ReleaseVF

The ReleaseVF function previously used `conf.MAC != ""` to guard the
effective MAC address restore during pod teardown. This condition only
triggers when the user explicitly sets a MAC via CNI config/annotation,
but the effective MAC may have been changed by the driver or other
processes regardless of user configuration.

Change the guard to `conf.OrigVfState.EffectiveMAC != ""` so the
effective MAC is always restored when it was captured during SetupVF,
matching the pattern already used by other fields like MTU
(`conf.OrigVfState.MTU != 0`) and the recent fix to ResetVFConfig
for admin MAC (`conf.OrigVfState.AdminMAC != ""`).

Signed-off-by: Sebastian Sch <sebassch@gmail.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

970 of 1544 relevant lines covered (62.82%)

8.73 hits per line