ReactiveX / RxPY

94%

master: 93%

LAST BUILD ON BRANCH fix/694-window-time-or-count-sync

branch: fix/694-window-time-or-count-sync

CHANGE BRANCH

x

Reset

• fix/694-window-time-or-count-sync
• 1.6.1
• add-repo-assist
• add-starmap-tests
• alpha3
• bo/fixup-docs
• ci/adopt-easybuild-shipit
• ci/dependabot-conventional-titles
• ci/enable-dependabot
• ci/shipit-3.0.1-and-dep-upgrades
• ci/shipit-allow-master
• ci/shipit-fix-historical-versions
• ci/shipit-skip-invalid-commit
• ci/upgrade-gh-aw-v0.71.5
• current
• curry-flip
• dependabot/github_actions/github-actions-0fd2d1971d
• dependabot/github_actions/github-actions-1bf0e6df77
• dependabot/github_actions/github-actions-468a2d4822
• dependabot/github_actions/github-actions-7b8ba4dc16
• dependabot/github_actions/github-actions-8827d84614
• dependabot/github_actions/github-actions-a12e56bff0
• dependabot/github_actions/github-actions-c020ac0c2c
• dependabot/github_actions/github-actions-c8a564380f
• dependabot/github_actions/github-actions-d95291362f
• dependabot/uv/python-dependencies-aeda4b483a
• develop
• docs
• docs-version
• docs/fix-build-and-5.0-refresh
• docs/fix-version-on-readthedocs
• docs/gil-section-corrections
• docs/parallelism-within-stream
• drop38
• feat/switch_map
• feat/tap-operator
• feature/add-project-cfg
• feature/disposable
• feature/doc-fixes
• feature/docs
• feature/fix-async-examples
• feature/fix-observer-throws
• feature/non-recursive
• feature/pipe-typing
• feature/py.typed
• feature/readthedocs
• feature/release-v3
• feature/rtd-badge
• feature/rxpy-3.0
• feature/subscribe-scheduler
• feature/to_iterabe_returns_list
• feature/typing-fixes
• fix-compose-pipe
• fix-defer-docs
• fix-docs
• fix-library-version
• fix-publish-version
• fix-publish-version-2
• fix-readme
• fix-subscribeon
• fix-timeflies-tkinter
• fix-typing
• fix-typo-occured-run-py
• fix-version
• fix-withlatestfrom
• fix/709-concurrent-futures
• fix/bump-script-lock-and-sed
• fix/scheduler-now-wall-clock
• fix/tkinter-test-skip-pypy-linux
• flake8-repo
• fluent-style
• format-tests
• gi-require_version-before-import
• github-publish
• improvement/combine-latest-thread-safety
• issue-697
• master
• migrate-to-uv
• modern-typehints
• optimize-build
• package-name
• patch-1
• poetry
• poetry-cache
• pre-commit
• pre-release
• py314
• pyright-254
• python-3.11
• reactivex
• reactivex-rename
• release/5.0.0-rc.1
• release/5.0.0-rc.2
• release/master
• release/stable-5.0.0
• release/v1.6.x
• release/v2.0.x
• release/v3.2.x
• repo-assist/eng-pyright-test-scheduler-2026-04-17-762f95f7e6558b77
• repo-assist/eng-uv-caching-2026-04-25-5d8d9a4690702132
• repo-assist/fix-issue-480-scheduler-forwarding-ea9c5c512fb11be9
• repo-assist/fix-issue-697-timer-resubscription-1e703fbea58df523
• repo-assist/fix-issue-712-retry-resubscription-2b9941042da6d10e
• repo-assist/improve-typing-exports-2026-04-18-60f123bfd9e95e24
• repo-assist/pyright-cleanup-test-observable-2026-04-26-3187c4c0696b18d4
• repo-assist/pyright-cleanup-test-observable-2026-05-01-7222f55d1674f33a
• repo-assist/pyright-cleanup-test-subject-scheduler-2026-04-17-e214b615e3b8b313
• repo-assist/pyright-ruff-cleanup-test-observable-scheduler-2026-04-21-6f569da2d139f64e
• repo-assist/test-exclusive-operator-2026-05-02-2b47081797817f4d
• repo-assist/testing-improvements-2026-04-17-5e55b8d05a9bf3ee
• return-types
• revert-120-multiprocessing
• rmahfoud/fixes
• timeout-on-event-loop
• type-fixes
• update-actions-cache
• update-code-checks
• update-pyright
• upgrade-deps
• upgrade-pyright
• use-ruff
• v1.5.9
• v3.0.0
• v3.0.1
• v3.1.0
• v3.1.0_se2
• v3.1.1
• v4
• v4.0.0
• v4.0.0a4
• v4.0.0a5
• v4.0.0a6
• v4.0.0b1
• v4.0.0b2
• v4.0.0b3
• v4.0.0b4
• v4.0.0b5
• v4.0.1
• v4.0.2
• v4.0.3
• v4.0.4
• v4.1.0
• v5.0.0a1
• v5.0.0a2
• vnext
• window-thread-issue

Build # 30341405946

Build Type

Pull #812

github

Committed by dbrattli

Commit Message

fix(operators): synchronize window_with_time_or_count

The window state (`n`, `s`, `window_id`) was mutated from both the source
thread (`on_next`) and the scheduler thread (the timer `action`) with no
synchronization.

When the timer closes a window it calls `s.on_completed()` before
reassigning `s = Subject()`. `on_completed()` synchronously runs the whole
downstream chain, so while any user work is in progress the source thread
keeps calling `s.on_next(x)` on a subject that has already completed, and
those items are silently discarded.

Guard `action`, `on_next`, `on_error` and `on_completed` with
`synchronized(source.lock)`, matching what `window_with_time` already does
and what Rx.NET's `WindowTimeCount` does with its gate. `buffer_with_time_
or_count` is built on this operator and was affected too.

Fixes #694

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #812: fix(operators): synchronize window_with_time_or_count

Coverage Stats

24 of 24 new or added lines in 2 files covered. (100.0%)

25736 of 27525 relevant lines covered (93.5%)

0.94 hits per line