Qiskit / qiskit
88%
main: 88%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-14837-49f9cbc317d736ef2138d9be4396c2a826004899
DEFAULT BRANCH: main
Repo Added
Files 869
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/stable/2.0/pr-14004-5a1016908f35f57a16b6c55cf51086e685afbda7
branch: gh-readonly-queue/stable/2.0/pr-14004-5a1016908f35f57a16b6c55cf51086e685afbda7
CHANGE BRANCH
x

coverage: 88.102% (-0.02%) from 88.124%
13816962474

push

github

web-flow 
Fix string and standard gate mismatch in commutation checker (backport #13991) (#14004)

* Fix string and standard gate mismatch in commutation checker (#13991)

* Fix string and standard gate mismatch in commutation checker

This commit reworks the internals of the CommutationChecker to not rely
on operation name except for where we do a lookup by name in the
commutation library provided (which is the only key available to support
custom gates). This fixes the case where a custom gate that overloads
the standard gate name, previously the code would assume it to be a
standard gate and internally panic when it wasn't. When working with
standard gates (or standard instructions) we don't need to rely on
string matching because we can rely on the rust data model to do the
heavy lifting for us. This commit moves all the explicit handling of
standard gates to use the StandardGate type directly and makes this
logic more robust.

This also removes are usage of the once_cell library in
qiskit-accelerate because it was used to create a lazy static hashsets
of strings which are no longer needed because static lookup tables replace
this when we stopped using string comparisons.

Fixes #13988

* Rename is_commutation_skipped() is_parameterized()

(cherry picked from commit abb0cf9db)

# Conflicts:
#	crates/accelerate/src/commutation_checker.rs

* Update commutation_checker.rs

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

47 of 91 new or added lines in 1 file covered. (51.65%)

9 existing lines in 2 files now uncovered.

72628 of 82436 relevant lines covered (88.1%)

496551.8 hits per line

Relevant lines Covered
82436 RELEVANT LINES 72628 COVERED LINES
496551.8 HITS PER LINE
Source Files on gh-readonly-queue/stable/2.0/pr-14004-5a1016908f35f57a16b6c55cf51086e685afbda7

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13816962474 gh-readonly-queue/stable/2.0/pr-14004-5a1016908f35f57a16b6c55cf51086e685afbda7 Fix string and standard gate mismatch in commutation checker (backport #13991) (#14004) * Fix string and standard gate mismatch in commutation checker (#13991) * Fix string and standard gate mismatch in commutation checker This commit reworks t... push web-flow github
88.1
See All Builds (13834)