Qiskit / qiskit
88%
main: 88%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-15122-bfd268c1b109b7023bf0b294f289c96d55000a00
DEFAULT BRANCH: main
Repo Added
Files 872
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-15220-aaff6c56bb8d900ba8f9f669bb15051cc0fc30e3
branch: gh-readonly-queue/main/pr-15220-aaff6c56bb8d900ba8f9f669bb15051cc0fc30e3
CHANGE BRANCH
x

coverage: 88.214% (+0.009%) from 88.205%
18711329687

push

github

web-flow 
Document subclass considerations for `Target` (#15220)

* Document subclass considerations for `Target`

The documentation of `Target` previously implied that subclassing it is
ok, and we have users that have done that.  However, subclassing it is
fragile, does not affect any transpiler pass that reads from the
`Target` in Rust space, and requires the subclass to arrange for
`__new__` to be called correctly.  I re-added a `**kwargs` variadic in
`Target.__new__` as a minor convenience; subclasses that only add
keyword-only arguments (which are generally the safest things to add)
will remain functional.  Had `Target.__new__` been defined in terms of
keyword-only arguments, we could also have added an `*args` munch too,
but as it is, adding or modifying the positional arguments to a `Target`
subclass constructor _always_ requires overriding `__new__` as well to
avoid clobbering positional `description`, `num_qubits`, etc, so there's
no benefit to having `*args`.

We should be discouraging users from subclassing `Target`; even our own
subclass of the Python-space `Target` from the Rust-space `Target` is
rather fragile with how we attempt to keep data in sync between the two.
Most APIs exposing a `Target` to their users would probably be better as
constructor functions; this is supposed to be the default way of
building a `Target`.

* Reexplain constructors vs subclassing

---------

Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>

1 of 1 new or added line in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

93463 of 105950 relevant lines covered (88.21%)

1157684.7 hits per line

Relevant lines Covered
105950 RELEVANT LINES 93463 COVERED LINES
1157684.7 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-15220-aaff6c56bb8d900ba8f9f669bb15051cc0fc30e3

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
18711329687 gh-readonly-queue/main/pr-15220-aaff6c56bb8d900ba8f9f669bb15051cc0fc30e3 Document subclass considerations for `Target` (#15220) * Document subclass considerations for `Target` The documentation of `Target` previously implied that subclassing it is ok, and we have users that have done that. However, subclassing it is... push web-flow github
88.21
See All Builds (14220)