Qiskit / qiskit
88%
main: 88%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-15094-96f5c08b3f54acfcc9552a34bf1bcc5402e07e7f
DEFAULT BRANCH: main
Repo Added
Files 868
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-14391-bfd81305e24d0db3d41d4a0e64af6649ac811081
branch: gh-readonly-queue/main/pr-14391-bfd81305e24d0db3d41d4a0e64af6649ac811081
CHANGE BRANCH
x

coverage: 88.328% (+0.02%) from 88.311%
15169980222

push

github

web-flow 
Avoid using string parsing for ParameterExpression.sympify() (#14391)

* Avoid using string parsing for ParameterExpression.sympify()

In the recently merged #13278 the implementation for the sympify
method for ParameterExpression was changed because we no longer rely on
symengine internally. Previously we would just return the inner
symengine object used to represent the symbolic expression. Without
symengine available #13278 updated the implementation of the method to
generate a string representation of the expression and pass that to
sympify which has a "parser" for converting that expression string to a
sympy object. However, sympify() method is insecure as it internally
relies on Python's eval() to parse the string and can't be used for
untrusted input. While this doesn't have the same exact exposure as
in https://github.com/Qiskit/qiskit/security/advisories/GHSA-6m2c-76ff-6vrf
because you have to opt-in to using this function with input that is
untrusted and the degrees of freedom are less because it has to go
through the rust symbolic expression it is still a potential
vulnerability waiting to happen. This commit reworks the sympify
implementation to avoid using sympy's parser and instead just builds
the sympy expression from the internal state directly.

* Remove unused Rust functions that support sympy string generation

* Add test coverage for all of parameter expression

* Add .sign() to the megaexpression

47 of 47 new or added lines in 2 files covered. (100.0%)

9 existing lines in 2 files now uncovered.

78479 of 88850 relevant lines covered (88.33%)

468382.79 hits per line

Relevant lines Covered
88850 RELEVANT LINES 78479 COVERED LINES
468382.79 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-14391-bfd81305e24d0db3d41d4a0e64af6649ac811081

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
15169980222 gh-readonly-queue/main/pr-14391-bfd81305e24d0db3d41d4a0e64af6649ac811081 Avoid using string parsing for ParameterExpression.sympify() (#14391) * Avoid using string parsing for ParameterExpression.sympify() In the recently merged #13278 the implementation for the sympify method for ParameterExpression was changed beca... push web-flow github
88.33
See All Builds (13861)