Qiskit / qiskit
88%
main: 88%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-15094-96f5c08b3f54acfcc9552a34bf1bcc5402e07e7f
DEFAULT BRANCH: main
Repo Added
Files 868
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-14164-7f3bd10b888971ed7987a868ad72c935e0929fe3
branch: gh-readonly-queue/main/pr-14164-7f3bd10b888971ed7987a868ad72c935e0929fe3
CHANGE BRANCH
x

coverage: 88.074% (+0.009%) from 88.065%
14273405234

push

github

web-flow 
Split DAGCircuit::compose() into Rust and python (#14164)

* Split DAGCircuit::compose() into Rust and python

The DAGCircuit::compose() method was previously implemented using most
of the logic via python. Basically it was all python just implemented
via PyO3 calls. This limited the performance of the function, but also
potentially more importantly meant that we didn't have an internal
Rust mechanism for running dag circuit composition. This commit seeks to
address this by splitting out the Python interface from the rust
implementation and rewriting the internals to operate on the Rust data
model directly instead of going through python. The `DAGCircuit::compose()`
method becomes the rust function for doing composition, and
`DAGCircuit::py_compose()` is the python interface.

Ideally we'd be able to drop the Python token argument from the new
`DAGCircuit::compose()` too, but because of
`DAGCircuit::apply_operation_back()` and handling of Vars this wasn't
worth the effort of using `Python::with_gil()` since we'd
unconditionally need the gil. Once `apply_operation_back()` no longer
needs the GIL, we should be able to drop the py argument from compose
too.

* Fix failing control flow tests

The control flow var handling was assuming that the underlying
instruction objects were copied during a compose() instead of mutated in
place with the updates. This commit corrects the oversight to fix the
failing tests.

* Remove pointless front argument from rust interface

* Lazily instantiate PyVariableMapper

* Update crates/circuit/src/dag_circuit.rs

* Fixes from code review

210 of 251 new or added lines in 1 file covered. (83.67%)

6 existing lines in 1 file now uncovered.

72961 of 82841 relevant lines covered (88.07%)

377041.03 hits per line

Relevant lines Covered
82841 RELEVANT LINES 72961 COVERED LINES
377041.03 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-14164-7f3bd10b888971ed7987a868ad72c935e0929fe3

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
14273405234 gh-readonly-queue/main/pr-14164-7f3bd10b888971ed7987a868ad72c935e0929fe3 Split DAGCircuit::compose() into Rust and python (#14164) * Split DAGCircuit::compose() into Rust and python The DAGCircuit::compose() method was previously implemented using most of the logic via python. Basically it was all python just impleme... push web-flow github
88.07
See All Builds (13860)