Qiskit / qiskit
88%
main: 88%

LAST BUILD BRANCH: fix-consolidate-blocks-recursion
DEFAULT BRANCH: main
Repo Added
Files 868
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-14109-4de7c93e02f1d91069769c04de28542f9cefa700
branch: gh-readonly-queue/main/pr-14109-4de7c93e02f1d91069769c04de28542f9cefa700
CHANGE BRANCH
x

coverage: 88.079% (-0.002%) from 88.081%
14108321713

push

github

web-flow 
Correctly handle non-UnitaryGate gates named "unitary" (#14109)

Normally creating a custom gate class that overloads the name of a
Qiskit defined operation is not valid and not allowed. The names have
meaning and are often used as identifiers and this overloading the name
will prevent Qiskit from correctly identifying an operation. However as
was discovered in #14103 there are some paths available around
serialization and I/O where Qiskit does this itself. For example, qasm
(both 2 and 3) is a lossy serialization format and qasm2 doesn't have a
representation of a UnitaryGate. So when the qasm2 exporter encounteres
a `UnitaryGate` it is serialized as a custom gate definition with the
name "unitary" in the output qasm2 and the definition is a decomposition
of the unitary from the `UnitaryGate`. When that qasm2 program is
subsequently deserialized by qiskit parser the custom gate named "unitary"
is added as a `_DefinedGate` subclass which includes an `__array__`
implementation which computes the unitary from the definition using
the quantum info Operator class. This makes the custom gate parsed from
qasm2 look like a `UnitaryGate` despite not actually one so this is
typically fine for most use cases. However, since #13759 trying to add
that not `UnitaryGate` object named "unitary" would cause the Python ->
Rust translation to panic (which happens as part of qasm2
desierailzation). because the conversion was expecting a gate named
`unitary` to be a `UnitaryGate` as is prescribed by the data model.

This commit fixes this by gracefully handling the lack of a matrix
parameter as it not actually being a `UnitaryGate` and instead the
object gets treated as a `PyGate` in rust which is the expected
behavior.

Related to #14103

1 of 1 new or added line in 1 file covered. (100.0%)

14 existing lines in 2 files now uncovered.

72748 of 82594 relevant lines covered (88.08%)

366960.82 hits per line

Relevant lines Covered
82594 RELEVANT LINES 72748 COVERED LINES
366960.82 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-14109-4de7c93e02f1d91069769c04de28542f9cefa700

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
14108321713 gh-readonly-queue/main/pr-14109-4de7c93e02f1d91069769c04de28542f9cefa700 Correctly handle non-UnitaryGate gates named "unitary" (#14109) Normally creating a custom gate class that overloads the name of a Qiskit defined operation is not valid and not allowed. The names have meaning and are often used as identifiers and... push web-flow github
88.08
See All Builds (13835)