Qiskit / qiskit
87%
main: 88%

LAST BUILD BRANCH: upload-c-binaries
DEFAULT BRANCH: main
Repo Added
Files 871
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-13917-af52fd9788996e1992fd1111186d59b1a021c7b6
branch: gh-readonly-queue/main/pr-13917-af52fd9788996e1992fd1111186d59b1a021c7b6
CHANGE BRANCH
x

coverage: 87.005% (-0.05%) from 87.055%
13683492936

push

github

web-flow 
Handle an optional symengine and sympy in qpy (#13917)

* Document that symengine is optional for qpy.load

This commit changes the API for qpy.load() to make it explicit that
symengine may not be installed in the future but is a requirement for
deserializing certain payloads that were generated using symengine.
We're expecting to drop symengine as a requirement with #13278 which
should improve Qiskit's installation story and also will facilitate
adding a C api for circuits. But the qpy v10, v11, and v13 have a hard
requirement on symengine (specifically 0.11.0 and 0.13.0) to be able to
deserialize `ParameterExpression` if the symbolic encoding was set to
use it. Since the function needs to support being able to deserialize
these payloads symengine will need to be installed. This commit adds the
document and release note to indicate this change in behavior.

* Raise QPY compatibility version to remove symengine and sympy dependency

This commit raises the qpy compatibility version to QPY format version
13. As the larger PR is planning for a world without symengine installed
by default this becomes a problem for the generation side too. This
becomes a blocker for using QPY < 13 in the future so this commit opts
to just raise the minimum verison to get ahead of any potential issues.

* Add HAS_SYMENGINE check on load function

* Correct logic for ucr*_dg gates name changing

* Add feature string to optional decorator

* Prepare for an optional sympy

In addition to making symengine optional #13278 should also enable us to
make sympy optional. It would only be potentially needed for loading QPY
payloads that were generated using sympy encoding, but also some
visualization functions. This commit lays the groundwork for removing it
as a dependency by outlining the API changes for the functions that will
optionally depend on sympy and raise an exception if it's not installed.
It won't be possible to trigger the exception with sympy in the
requirements list,... (continued)

26 of 29 new or added lines in 8 files covered. (89.66%)

44 existing lines in 5 files now uncovered.

76082 of 87446 relevant lines covered (87.0%)

326550.2 hits per line

Relevant lines Covered
87446 RELEVANT LINES 76082 COVERED LINES
326550.2 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-13917-af52fd9788996e1992fd1111186d59b1a021c7b6

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13683492936 gh-readonly-queue/main/pr-13917-af52fd9788996e1992fd1111186d59b1a021c7b6 Handle an optional symengine and sympy in qpy (#13917) * Document that symengine is optional for qpy.load This commit changes the API for qpy.load() to make it explicit that symengine may not be installed in the future but is a requirement for d... push web-flow github
87.0
See All Builds (13940)