Qiskit / qiskit
88%
main: 88%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-15094-96f5c08b3f54acfcc9552a34bf1bcc5402e07e7f
DEFAULT BRANCH: main
Repo Added
Files 868
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-13811-a00279bc7d6005bfc5ea783cd1fe336784160518
branch: gh-readonly-queue/main/pr-13811-a00279bc7d6005bfc5ea783cd1fe336784160518
CHANGE BRANCH
x

coverage: 88.11% (+0.001%) from 88.109%
13579887874

push

github

web-flow 
[Stretch] Support `const` classical expressions. (#13811)

* WIP

* Add try_const to lift.

* Try multiple singletons, new one for const.

* Revert "Try multiple singletons, new one for const."

This reverts commit e2b322125.

* Remove Bool singleton test.

* Add const handling for stores, fix test bugs.

* Fix formatting.

* Remove Duration and Stretch for now.

* Cleanup, fix const bug in index.

* Fix ordering issue for types with differing const-ness.

Types that have some natural order no longer have an ordering
when one of them is strictly greater but has an incompatible
const-ness (i.e. when the greater type is const but the other
type is not).

* Fix QPY serialization.

We need to reject types with const=True in QPY until it supports them.

For now, I've also made the Index and shift operator constructors
lift their RHS to the same const-ness as the target to make it
less likely that existing users of expr run into issues when
serializing to older QPY versions.

* Make expr.Lift default to non-const.

This is probably a better default in general, since we
don't really have much use for const except for timing
stuff.

* Revert to old test_expr_constructors.py.

* Make binary_logical lift independent again.

Since we're going for using a Cast node when const-ness
differs, this will be fine.

* Update tests, handle a few edge cases.

* Fix docstring.

* Remove now redundant arg from tests.

* Add const testing for ordering.

* Add const tests for shifts.

* Add release note.

* Add const store tests.

* Address lint, minor cleanup.

* Reject const vars in add_var and add_input.

Also removes the assumption that a const-type can never be an l-value
in favor of just restricting l-values with const types from being
added to circuits for now.

We will (in a separate PR) add support for adding stretch variables
to circuits, which are const. However, we may track those
differently, or at least not report them as variable ... (continued)

9 of 9 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

77521 of 87982 relevant lines covered (88.11%)

347479.14 hits per line

Relevant lines Covered
87982 RELEVANT LINES 77521 COVERED LINES
347479.14 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-13811-a00279bc7d6005bfc5ea783cd1fe336784160518

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13579887874 gh-readonly-queue/main/pr-13811-a00279bc7d6005bfc5ea783cd1fe336784160518 [Stretch] Support `const` classical expressions. (#13811) * WIP * Add try_const to lift. * Try multiple singletons, new one for const. * Revert "Try multiple singletons, new one for const." This reverts commit e2b32212533a52b30fecb700ed36a7f9... push web-flow github
88.11
See All Builds (13861)