Qiskit / qiskit
89%
main: 88%

LAST BUILD BRANCH: fix-duration
DEFAULT BRANCH: main
Repo Added
Files 870
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-13752-3c805dd7992e8e8b8f7a20bcb6aca121dbe62288
branch: gh-readonly-queue/main/pr-13752-3c805dd7992e8e8b8f7a20bcb6aca121dbe62288
CHANGE BRANCH
x

coverage: 88.815% (-0.1%) from 88.936%
13054892992

push

github

web-flow 
Add merging of `Interner`s (#13752)

* Add merging of `Interner` instances

This makes it possible to merge one interner into another, using a
map-and-filter function to explain how the values should be considered
afterwards.  The main use-case for this is in DAG and circuit
substitution methods, where we want to be able to map
`PackedInstruction`s from a small circuit to new ones on a larger
circuit, without having to unwrap and re-hash the interned slices once
for instruction; instead, we do that once _per interner key_, and then
have a no-hash direct lookup table to remap the interner keys directly.

The methods here are designed to directly allow the reuse of the heap
allocations used to track the interner key mappings, to help reduce the
number of small-scale allocations done in substitution methods.

The filtering part of the mapping is because one cannot typically be
certain that an `Interner` contains the minimally necessary keys,
especially for DAGs; it can well be that substitutions and bit removals
cause old data to be present.

* Use new `Interner` merging in `DAGCircuit::from_circuit`

This converts one obvious candidate for the new interner-merging
functionality.  There are several others in the codebase (all uses of
`DAGCircuit::extend`, for example, and several other full rebuilds), but
the structure of their code wasn't designed with this in mind, so the
modifications would typically be far more involved and more suitable for
separate patches.

Using a timing script:

```python
        import itertools
        from qiskit.circuit import QuantumCircuit
from qiskit.converters import circuit_to_dag

qc = QuantumCircuit(100, 100)
for pair in itertools.permutations(qc.qubits, 2):
    qc.rz(0, pair[0])
    qc.sx(pair[0])
    qc.rz(0, pair[0])
    qc.rz(0, pair[1])
    qc.sx(pair[1])
    qc.rz(0, pair[1])
    qc.cx(*pair)

%timeit circuit_to_dag(qc, copy_operations=False)
```

this patch showed an improvement from 18.5(6)ms to 14.4(5)ms on m... (continued)

123 of 253 new or added lines in 2 files covered. (48.62%)

11 existing lines in 3 files now uncovered.

79761 of 89806 relevant lines covered (88.81%)

346389.92 hits per line

Relevant lines Covered
89806 RELEVANT LINES 79761 COVERED LINES
346389.92 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-13752-3c805dd7992e8e8b8f7a20bcb6aca121dbe62288

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13054892992 gh-readonly-queue/main/pr-13752-3c805dd7992e8e8b8f7a20bcb6aca121dbe62288 Add merging of `Interner`s (#13752) * Add merging of `Interner` instances This makes it possible to merge one interner into another, using a map-and-filter function to explain how the values should be considered afterwards. The main use-case fo... push web-flow github
88.81
See All Builds (13918)