Qiskit / qiskit
89%
main: 88%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-15094-96f5c08b3f54acfcc9552a34bf1bcc5402e07e7f
DEFAULT BRANCH: main
Repo Added
Files 868
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-13736-cc7ac5312b71295defdf4b8acbe6673a39889c91
branch: gh-readonly-queue/main/pr-13736-cc7ac5312b71295defdf4b8acbe6673a39889c91
CHANGE BRANCH
x

coverage: 88.95% (+0.03%) from 88.922%
13000269683

push

github

web-flow 
Remove sort_key attribute from DAGNode (#13736)

* Remove sort_key attribute from DAGNode

Prior to having the DAGCircuit in rust the `sort_key` attribute was added
as a cache to speed up the lexicographical topological sort. Prior to
having this attribute the topological sort method would compute the sort
key as a string on the fly which ended up being a large bottleneck in
transpilation (see: #4040 for more details). However, since migrating
the DAGCircuit implementation to Rust this sort_key attribute isn't
needed anymore because we call the rustworkx-core function with a tuple
of bit objects instead of a string. The `sort_key` atribute was left on
in place for backwards compatibility (it shouldn't have been public,
this was a mistake in #4040) and when we create a python DAGNode object
that will be returned to Python the creation of the sort key is
unnecessary overhead (it takes roughly 1% of profile time to format the
sort_key string during transpilation). Since nothing in DAGCircuit is
actually using it this commit removes it to save the CPU cycles
creating the string on each dag creation. We will need to add a
deprecation to 1.4.0 to mark this removal for 2.0.0 since this was
missed in 1.3.0.

* Simplify star pre-routing sort_key logic

32 of 32 new or added lines in 4 files covered. (100.0%)

4 existing lines in 2 files now uncovered.

79689 of 89589 relevant lines covered (88.95%)

348152.78 hits per line

Relevant lines Covered
89589 RELEVANT LINES 79689 COVERED LINES
348152.78 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-13736-cc7ac5312b71295defdf4b8acbe6673a39889c91

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13000269683 gh-readonly-queue/main/pr-13736-cc7ac5312b71295defdf4b8acbe6673a39889c91 Remove sort_key attribute from DAGNode (#13736) * Remove sort_key attribute from DAGNode Prior to having the DAGCircuit in rust the `sort_key` attribute was added as a cache to speed up the lexicographical topological sort. Prior to having this ... push web-flow github
88.95
See All Builds (13861)