Qiskit / qiskit
88%
main: 88%

LAST BUILD BRANCH: struct-eq
DEFAULT BRANCH: main
Repo Added
Files 871
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-13733-ea7c3e35ebaf0ea62b3354b251d33856ccea31dd
branch: gh-readonly-queue/main/pr-13733-ea7c3e35ebaf0ea62b3354b251d33856ccea31dd
CHANGE BRANCH
x

coverage: 88.111% (+0.01%) from 88.098%
13460806330

push

github

web-flow 
Bump rustworkx-core and hashbrown to latest releases (#13733)

* Bump rustworkx-core and hashbrown to latest releases

This commit bumps the rustworkx-core and hashbrown dependencies to the
latest releases. We were previously blocked on upgrading hashbrown
because we use it to exchange data with rustworkx-core and
rustworkx-core 0.15.x depended on the previous release of hashbrown. But
with the new release of rustworkx-core 0.16.0 it is using the latest
release of hashbrown and we can bump both at the same time.

One thing we'll want to do is upgrade our ndarray version in the future
because rustworkx-core uses 0.16 now, but we're blocked on that by our
einsum library at the momemnt. Luckily we don't exchange arrays with
rustworkx at the moment in rust. But this will become an issue if we do.

* Use IndexMap for basis translator

The basis translator implementation is sensitive to iteration order in
parts for places HashMaps and HashSets were being used. We used to get
by when hashbrown was using ahash and the iteration was likely
accidently deterministic for the types we were putting in them. However,
this wasn't an API guarantee and likely just a side effect of using u32s
in places. The latest hashbrown version changes the hashing algorithm to
use foldhash which is changing the iteration order. This was causing
test failures. This commit corrects this issue by switching every use of
hashbrown types to indexmap which has a deterministic iteration order.
The only exception is the input types to the run function, which still
uses hashbrown because pyo3 wasn't able to resolve the conversion
trait implementations when switching to indexmap types. This adds the
overhead of a copy, but this is a small price to pay for fixing the
iteration issue determinism.

* Add missing ahash usage on one indexmap

114 of 118 new or added lines in 5 files covered. (96.61%)

7 existing lines in 3 files now uncovered.

78392 of 88970 relevant lines covered (88.11%)

349111.59 hits per line

Relevant lines Covered
88970 RELEVANT LINES 78392 COVERED LINES
349111.59 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-13733-ea7c3e35ebaf0ea62b3354b251d33856ccea31dd

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13460806330 gh-readonly-queue/main/pr-13733-ea7c3e35ebaf0ea62b3354b251d33856ccea31dd Bump rustworkx-core and hashbrown to latest releases (#13733) * Bump rustworkx-core and hashbrown to latest releases This commit bumps the rustworkx-core and hashbrown dependencies to the latest releases. We were previously blocked on upgrading ... push web-flow github
88.11
See All Builds (13944)