Qiskit / qiskit
88%
main: 88%

LAST BUILD BRANCH: c-better-prefixing
DEFAULT BRANCH: main
Repo Added
Files 869
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-13506-67c740601d20032d4c13007940696b611640aa02
branch: gh-readonly-queue/main/pr-13506-67c740601d20032d4c13007940696b611640aa02
CHANGE BRANCH
x

coverage: 87.971% (-0.1%) from 88.112%
13502462770

push

github

web-flow 
Remove condition/c_if, duration, and unit from instructions (#13506)

* Remove condition/c_if, duration, and unit from instructions

This commit removes the per instruction attributes for condition,
duration, and unit. These attributes were deprecated in 1.3.0. Besides
the label these attributes were the only mutable state for singleton
instructions and removing them simplifies what needs to be tracked for
instructions in both Python and rust. The associated methods and classes
that were previously dependent on these attributes are also removed as
they no longer serve a purpose. The removal of condition in particular
removes a lot of logic from Qiskit especially from the transpiler
because it was a something that needed to be checked outside of the
normal data model for every operation.

This PR simplifies the representation of this extra mutable state in
Rust by removing the `ExtraInstructionAttributes` struct and replacing
it with a `Option<Box<String>>`. The `Option<Box<String>>` is used
instead of the simpler `Option<String>` because this this reduces the
size of the label field from 24 bytes for `Option<String>` to 8 bytes
for `Option<Box<String>>` with an extra layer of pointer indirection
and a second heap allocation. This will have runtime overhead when
labels are set, but because the vast majority of operations don't set
labels the tradeoff for optimizing for the None case makes more sense.
Another option would have been to use `Box<str>` here which is the
equivalent of `Box<[u8]>` (where `String` is the equivalent to
`Vec<u8>`) and from a runtime memory tradeoff would be a better
choice for this application if labels were commonly used as labels
aren't growable. But that requires 16 bytes instead of 8 and we'd be
wasting an additional 8 bytes for each instruction in the circuit which
isn't worth the cost.

* Update random_circuit

* Update more tests

* Fix new scheduling pass implementation

* Fix clippy::redundant_closure

* Add release no... (continued)

382 of 439 new or added lines in 80 files covered. (87.02%)

189 existing lines in 28 files now uncovered.

77749 of 88380 relevant lines covered (87.97%)

359318.33 hits per line

Relevant lines Covered
88380 RELEVANT LINES 77749 COVERED LINES
359318.33 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-13506-67c740601d20032d4c13007940696b611640aa02

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13502462770 gh-readonly-queue/main/pr-13506-67c740601d20032d4c13007940696b611640aa02 Remove condition/c_if, duration, and unit from instructions (#13506) * Remove condition/c_if, duration, and unit from instructions This commit removes the per instruction attributes for condition, duration, and unit. These attributes were deprec... push web-flow github
87.97
13500590125 gh-readonly-queue/main/pr-13506-67c740601d20032d4c13007940696b611640aa02 Remove condition/c_if, duration, and unit from instructions (#13506) * Remove condition/c_if, duration, and unit from instructions This commit removes the per instruction attributes for condition, duration, and unit. These attributes were deprec... push web-flow github
87.96
13499968149 gh-readonly-queue/main/pr-13506-67c740601d20032d4c13007940696b611640aa02 Remove condition/c_if, duration, and unit from instructions (#13506) * Remove condition/c_if, duration, and unit from instructions This commit removes the per instruction attributes for condition, duration, and unit. These attributes were deprec... push web-flow github
87.97
See All Builds (13886)