Qiskit / qiskit
89%
main: 88%

LAST BUILD BRANCH: gh-readonly-queue/main/pr-15094-96f5c08b3f54acfcc9552a34bf1bcc5402e07e7f
DEFAULT BRANCH: main
Repo Added
Files 868
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-13356-1b35e8bddf9f3a8acc29537c9c213b502a944b4e
branch: gh-readonly-queue/main/pr-13356-1b35e8bddf9f3a8acc29537c9c213b502a944b4e
CHANGE BRANCH
x

coverage: 88.804% (-0.009%) from 88.813%
11709257707

push

github

web-flow 
Add Qiskit native QPY ParameterExpression serialization (#13356)

* Add Qiskit native QPY ParameterExpression serialization

With the release of symengine 0.13.0 we discovered a version dependence
on the payload format used for serializing symengine expressions. This
was worked around in #13251 but this is not a sustainable solution and
only works for symengine 0.11.0 and 0.13.0 (there was no 0.12.0). While
there was always the option to use sympy to serialize the underlying
symbolic expression (there is a `use_symengine` flag on `qpy.dumps` you
can set to `False` to do this) the sympy serialzation has several
tradeoffs most importantly is much higher runtime overhead. To solve
the issue moving forward a qiskit native representation of the parameter
expression object is necessary for serialization.

This commit bumps the QPY format version to 13 and adds a new
serialization format for ParameterExpression objects. This new format
is a serialization of the API calls made to ParameterExpression that
resulted in the creation of the underlying object. To facilitate this
the ParameterExpression class is expanded to store an internal "replay"
record of the API calls used to construct the ParameterExpression
object. This internal list is what gets serialized by QPY and then on
deserialization the "replay" is replayed to reconstruct the expression
object. This is a different approach to the previous QPY representations
of the ParameterExpression objects which instead represented the internal
state stored in the ParameterExpression object with the symbolic
expression from symengine (or a sympy copy of the expression). Doing
this directly in Qiskit isn't viable though because symengine's internal
expression tree is not exposed to Python directly. There isn't any
method (private or public) to walk the expression tree to construct
a serialization format based off of it. Converting symengine to a sympy
expression and then using sympy's API to walk the expression tr... (continued)

272 of 293 new or added lines in 5 files covered. (92.83%)

19 existing lines in 5 files now uncovered.

77554 of 87332 relevant lines covered (88.8%)

359927.84 hits per line

Relevant lines Covered
87332 RELEVANT LINES 77554 COVERED LINES
359927.84 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-13356-1b35e8bddf9f3a8acc29537c9c213b502a944b4e

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
11709257707 gh-readonly-queue/main/pr-13356-1b35e8bddf9f3a8acc29537c9c213b502a944b4e Add Qiskit native QPY ParameterExpression serialization (#13356) * Add Qiskit native QPY ParameterExpression serialization With the release of symengine 0.13.0 we discovered a version dependence on the payload format used for serializing symengi... push web-flow github
88.8
See All Builds (13861)