Qiskit / qiskit
89%
main: 89%

LAST BUILD BRANCH: BD-add-alt-text
DEFAULT BRANCH: main
Repo Added
Files 913
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-13251-f1b25806e97674428b8d687bd5886f23fd6cbe80
branch: gh-readonly-queue/main/pr-13251-f1b25806e97674428b8d687bd5886f23fd6cbe80
CHANGE BRANCH
x

coverage: 88.858% (-0.006%) from 88.864%
11143927628

push

github

web-flow 
Workaround symengine serialization payload incompatibility (#13251)

* Workaround symengine serialization payload incompatibility

In QPY we rely on symengine's internal serialization to represent the
internal symbolic expression stored inside a ParameterExpression object.
However, this format is nominally symengine version specific and will
raise an error if there is a mismatch between the version used to
generate the payload and what is trying to read it. This became an issue
in the recent symengine 0.13 release which started to raise an error
when people installed it and tried to load QPY payloads across the
versions. This makes the symengine serialization unsuitable for use in
QPY because it's supposed to be independent of these kind of concerns,
especially when QPY is used in a server-client model where you don't
necessarily control the installed environment of symengine.

To correctly address this issue we'll need a new version of the QPY
format that owns the serialization format of ParameterExpressions directly
instead of relying on symengine which doesn't offer a compatibility
guarantee on the format. However this won't be quick solution and users
are encountering issues since the release of 0.13. This commit
introduces a workaround for this specific instance of the mismatch. It
turns out the payload format between 0.11 and 0.13 is completely
unchanged except for the version number. So before passing the parameter
expression payload to symengine for deserialization this commit checks
the versions numbers are the same, if they're not it checks that we're
dealing with 0.11 or 0.13, and if so it changes the version number in
the payloads header appropriately. If the version number is outside
those bounds it raises an exception because while this hack is known to
be safe for translating between symengine 0.11 and 0.13, it's not
possible to know for a future version whether the payload format changed
or not.

Longer term we will need a proper fix i... (continued)

11 of 23 new or added lines in 3 files covered. (47.83%)

15 existing lines in 2 files now uncovered.

74147 of 83444 relevant lines covered (88.86%)

375241.07 hits per line

Relevant lines Covered
83444 RELEVANT LINES 74147 COVERED LINES
375241.07 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-13251-f1b25806e97674428b8d687bd5886f23fd6cbe80

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
11143927628 gh-readonly-queue/main/pr-13251-f1b25806e97674428b8d687bd5886f23fd6cbe80 Workaround symengine serialization payload incompatibility (#13251) * Workaround symengine serialization payload incompatibility In QPY we rely on symengine's internal serialization to represent the internal symbolic expression stored inside a P... push web-flow github
88.86
See All Builds (9023)