Qiskit / qiskit
89%
main: 89%

LAST BUILD BRANCH: remove_deprecated_function_arguments/1
DEFAULT BRANCH: main
Repo Added
Files 914
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-13052-254ba83dc637a22a91cee0a0cd1c453f89ca55da
branch: gh-readonly-queue/main/pr-13052-254ba83dc637a22a91cee0a0cd1c453f89ca55da
CHANGE BRANCH
x

coverage: 89.091% (-0.05%) from 89.136%
10729421750

push

github

web-flow 
Fully port FilterOpNodes to Rust (#13052)

* Fully port FilterOpNodes to Rust

This commit ports the FilterOpNodes pass to rust. This pass is
exceedingly simple and just runs a filter function over all the op
nodes and removes nodes that match the filter. However, the API for
the class exposes that filter function interface as a user provided
Python callable. So for the current pass we need to retain that python
callback. This limits the absolute performance of this pass because
we're bottlenecked by calling python.

Looking to the future, this commit adds a rust native method to
DAGCircuit to perform this filtering with a rust predicate FnMut. It
isn't leveraged by the python implementation because of layer mismatch
for the efficient rust interface and Python working with `DAGOpNode`
objects. A function using that interface is added to filter labeled
nodes. In the preset pass manager we only use FilterOpNodes to remove
nodes with a specific label (which is used to identify temporary
barriers created by qiskit). In a follow up we should consider
leveraging this new function to build a new pass specifically for
this use case.

Fixes #12263
Part of #12208

* Make filter_op_nodes() infallible

The filter_op_nodes() method originally returned a Result<()> to handle
a predicate that was fallible. This was because the original intent for
the method was to use it with Python callbacks in the predicate. But
because of differences between the rust API and the Python API this
wasn't feasible as was originally planned. So this Result<()> return
wasn't used anymore. This commit reworks it to make the
filter_op_nodes() infallible and the predicate a user provides also only
returns `bool` and not `Result<bool>`.

* Rename filter_labelled_op to filter_labeled_op

30 of 60 new or added lines in 7 files covered. (50.0%)

23 existing lines in 3 files now uncovered.

72595 of 81484 relevant lines covered (89.09%)

387296.96 hits per line

Relevant lines Covered
81484 RELEVANT LINES 72595 COVERED LINES
387296.96 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-13052-254ba83dc637a22a91cee0a0cd1c453f89ca55da

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
10729421750 gh-readonly-queue/main/pr-13052-254ba83dc637a22a91cee0a0cd1c453f89ca55da Fully port FilterOpNodes to Rust (#13052) * Fully port FilterOpNodes to Rust This commit ports the FilterOpNodes pass to rust. This pass is exceedingly simple and just runs a filter function over all the op nodes and removes nodes that match the... push web-flow github
89.09
See All Builds (8713)