Qiskit / qiskit
90%
main: 89%

LAST BUILD BRANCH: BD-add-alt-text
DEFAULT BRANCH: main
Repo Added
Files 913
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-12794-441925e4cf16f058a927caf9145a599ac6782b41
branch: gh-readonly-queue/main/pr-12794-441925e4cf16f058a927caf9145a599ac6782b41
CHANGE BRANCH
x

coverage: 89.738% (+0.03%) from 89.706%
10196989909

push

github

web-flow 
Move `QuantumCircuit.assign_parameters` to Rust (#12794)

* Move `QuantumCircuit.assign_parameters` to Rust

This is (as far as I could tell), the last really major performance
regression in our asv suite compared to 1.1.0, so with this commit, we
should be at _not worse_ for important utility-scale benchmarks.

This largely rewrites `ParamTable` (renamed back to `ParameterTable`
because I kept getting confused with `Param`) to have more Rust-friendly
interfaces available, so that `assign_parameters` can then use them.

This represents a 2-3x speedup in `assign_parameters` performance over
1.1.0, when binding simple `Parameter` instances.  Approximately 75% of
the time is now spent in Python-space `Parameter.assign` and
`ParameterExpression.numeric` calls; almost all of this could be removed
were we to move `Parameter` and `ParameterExpression` to have their data
exposed directly to Rust space.  The percentage of time spent in Python
space only increases if the expressions to be bound are actual
`ParameterExpression`s and not just `Parameter`.

Most changes in the test suite are because of the use of internal-only
methods that changed with the new `ParameterTable`.  The only
discrepancy is a bug in `test_pauli_feature_map`, which was trying to
assign using a set.

* Add unit test of parameter insertion

This catches a bug that was present in the parent commit, but this PR
fixes.

* Update crates/circuit/src/imports.rs

* Fix assignment to `AnnotatedOperation`

* Rename `CircuitData::num_params` to match normal terminology

* Fix typos and :us:

* Fix lint

485 of 513 new or added lines in 5 files covered. (94.54%)

23 existing lines in 4 files now uncovered.

67281 of 74975 relevant lines covered (89.74%)

386934.51 hits per line

Relevant lines Covered
74975 RELEVANT LINES 67281 COVERED LINES
386934.51 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-12794-441925e4cf16f058a927caf9145a599ac6782b41

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
10196989909 gh-readonly-queue/main/pr-12794-441925e4cf16f058a927caf9145a599ac6782b41 Move `QuantumCircuit.assign_parameters` to Rust (#12794) * Move `QuantumCircuit.assign_parameters` to Rust This is (as far as I could tell), the last really major performance regression in our asv suite compared to 1.1.0, so with this commit, we... push web-flow github
89.74
See All Builds (9023)