Qiskit / qiskit
90%
main: 89%

LAST BUILD BRANCH: BD-add-alt-text
DEFAULT BRANCH: main
Repo Added
Files 913
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-12730-a335504abd52f4f08183fb276c187951bc40385e
branch: gh-readonly-queue/main/pr-12730-a335504abd52f4f08183fb276c187951bc40385e
CHANGE BRANCH
x

coverage: 89.892% (-0.03%) from 89.92%
10065191819

push

github

web-flow 
Rebalance `CircuitInstruction` and `PackedInstruction` (#12730)

* Rebalance `CircuitInstruction` and `PackedInstruction`

This is a large overhaul of how circuit instructions are both stored in
Rust (`PackedInstruction`) and how they are presented to Python
(`CircuitInstruction`).  In summary:

* The old `OperationType` enum is now collapsed into a manually managed
  `PackedOperation`.  This is logically equivalent, but stores a
  `PyGate`/`PyInstruction`/`PyOperation` indirectly through a boxed
  pointer, and stores a `StandardGate` inline.  As we expect the vast
  majority of gates to be standard, this hugely reduces the memory
  usage.  The enumeration is manually compressed to a single pointer,
  hiding the discriminant in the low, alignment-required bytes of the
  pointer.

* `PackedOperation::view()` unpacks the operation into a proper
  reference-like enumeration `OperationRef<'a>`, which implements
  `Operation` (though there is also a `try_standard_gate` method to get
  the gate without unpacking the whole enumeration).

* Both `PackedInstruction` and `CircuitInstruction` use this
  `PackedOperation` as the operation storage.

* `PackedInstruction` is now completely the Rust-space format for data,
  and `CircuitInstruction` is purely for communication with Python.

On my machine, this commit brings the utility-scale benchmarks to within
10% of the runtime of 1.1.0 (and some to parity), despite all the
additional overhead.

Changes to accepting and building Python objects
------------------------------------------------

* A `PackedInstruction` is created by copy constructor from a
  `CircuitInstruction` by `CircuitData::pack`.  There is no `pack_owned`
  (really, there never was - the previous method didn't take ownership)
  because there's never owned `CircuitInstruction`s coming in; they're
  Python-space interop, so we never own them (unless we clone them)
  other than when we're unpacking them.

* `PackedInstruction` is currently just cr... (continued)

753 of 800 new or added lines in 17 files covered. (94.13%)

76 existing lines in 9 files now uncovered.

65745 of 73138 relevant lines covered (89.89%)

301688.91 hits per line

Relevant lines Covered
73138 RELEVANT LINES 65745 COVERED LINES
301688.91 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-12730-a335504abd52f4f08183fb276c187951bc40385e

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
10065191819 gh-readonly-queue/main/pr-12730-a335504abd52f4f08183fb276c187951bc40385e Rebalance `CircuitInstruction` and `PackedInstruction` (#12730) * Rebalance `CircuitInstruction` and `PackedInstruction` This is a large overhaul of how circuit instructions are both stored in Rust (`PackedInstruction`) and how they are presente... push web-flow github
89.89
See All Builds (9023)