Qiskit / qiskit
90%
main: 89%

LAST BUILD BRANCH: unitary_synth
DEFAULT BRANCH: main
Repo Added
Files 913
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-12458-67fd35a2eacf977f0cd2539b7ae5b4c4210f50bf
branch: gh-readonly-queue/main/pr-12458-67fd35a2eacf977f0cd2539b7ae5b4c4210f50bf
CHANGE BRANCH
x

coverage: 89.832% (+0.005%) from 89.827%
9746514645

push

github

web-flow 
Add warning for bad `justify` input, in `circuit_drawer` (#12458)

* add warning for bad justify input in circuit_drawer

* change justify after raising error

* typo indentation + improving warning string

* Undo max_lenght limit by autoformater (120 > 105)

* Make lines fullfill 105 max lenght requirement

* Solve regex matching parenthesis problem and don't trigger the wanring for default value

* Change justify default value to "left", & add deprecation wrapper

* Change and extend warnings tests

* Solve various layers of same argument DeprecationWarning

* Added a clarification comment for the solution, about multiple deprecationwarnings

* Ignore cyclic import error, as above

* Apply suggestions from code review

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>

* Apply suggestions from code review

* Improve DeprecationWarning readability, and fix warning checks tests

* Remove `_is_valid_justify_arg` from `@deprecate_arg`, for solving circular import

* in `deprecate_arg` change `since` to "1.2.0"

* black formater suggestion

* negate conditions for `predicate` in `@deprecate_arg`

* remove `pending=True`, since then warning is not raised

* change qiskit version on tests

* remove assert Regex for DeprecationWarning

* Add release note, and remove two undesired changes in imports

* changing release note naming from "_" to "-"

* Add extra line in the end, for lint

* Redid release file from start, with shorter name, and correct spacings

* Remove final spaces in all lines...

* Try without deprecations_visualization section..

* Solve, bad Sphinx spacing, go back to deprecations_visualization

* Go back to `None` as default value

* Simplifying deprecation logic

* Remove unused imports and changed missing default value

* Improve docstring for public methods

* Improve error readbility and testing of it with regex

---------

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>

18 of 18 new or added lines in 2 files covered. (100.0%)

5 existing lines in 1 file now uncovered.

64414 of 71705 relevant lines covered (89.83%)

303883.37 hits per line

Relevant lines Covered
71705 RELEVANT LINES 64414 COVERED LINES
303883.37 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-12458-67fd35a2eacf977f0cd2539b7ae5b4c4210f50bf

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
9746514645 gh-readonly-queue/main/pr-12458-67fd35a2eacf977f0cd2539b7ae5b4c4210f50bf Add warning for bad `justify` input, in `circuit_drawer` (#12458) * add warning for bad justify input in circuit_drawer * change justify after raising error * typo indentation + improving warning string * Undo max_lenght limit by autoformater ... push web-flow github
89.83
See All Builds (9024)