Qiskit / qiskit
89%
main: 89%

LAST BUILD BRANCH: BD-add-alt-text
DEFAULT BRANCH: main
Repo Added
Files 913
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH gh-readonly-queue/main/pr-12134-166dcccd6921031a476093dae3ebd5640780542b
branch: gh-readonly-queue/main/pr-12134-166dcccd6921031a476093dae3ebd5640780542b
CHANGE BRANCH
x

coverage: 89.274% (-0.02%) from 89.292%
8727857117

push

github

web-flow 
Refactor Rust crates to build a single extension module (#12134)

* Refactor Rust crates to build a single extension module

Previously we were building three different Python extension modules out
of Rust space.  This was convenient for logical separation of the code,
and for making the incremental compilations of the smaller crates
faster, but had the disadvantage that `qasm2` and `qasm3` couldn't
access the new circuit data structures directly from Rust space and had
to go via Python.

This modifies the crate structure to put the Rust-space acceleration
logic into crates that we only build as Rust libraries, then adds
another (`pyext`) crate to be the only that that actually builds as
shared Python C extension.  This then lets the Rust crates interact with
each other (and the Rust crates still contain PyO3 Python-binding logic
internally) and accept and output each others' Python types.

The one Python extension is still called `qiskit._accelerate`, but it's
built by the Rust crate `qiskit-pyext`.  This necessitated some further
changes, since `qiskit._accelerate` now contains acccelerators for lots
of parts of the Qiskit package hierarchy, but needs to have a single
low-level place to initialise itself:

- The circuit logic `circuit` is separated out into its own separate
  crate so that this can form the lowest part of the Rust hierarchy.
  This is done so that `accelerate` with its grab-bag of accelerators
  from all over the place does not need to be the lowest part of the
  stack.  Over time, it's likely that everything will start touching
  `circuit` anyway.

- `qiskit._qasm2` and `qiskit._qasm3` respectively became
  `qiskit._accelerate.qasm2` and `qiskit._accelerate.qasm3`, since they
  no longer get their own extension modules.

- `qasm3` no longer stores a Python object on itself during module
  initialisation that depended on `qiskit.circuit.library` to create.
  Now, the Python-space `qiskit.qasm3` does that and the `qasm3` crate
  just... (continued)

94 of 97 new or added lines in 19 files covered. (96.91%)

25 existing lines in 3 files now uncovered.

60315 of 67562 relevant lines covered (89.27%)

234840.61 hits per line

Relevant lines Covered
67562 RELEVANT LINES 60315 COVERED LINES
234840.61 HITS PER LINE
Source Files on gh-readonly-queue/main/pr-12134-166dcccd6921031a476093dae3ebd5640780542b

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
8727857117 gh-readonly-queue/main/pr-12134-166dcccd6921031a476093dae3ebd5640780542b Refactor Rust crates to build a single extension module (#12134) * Refactor Rust crates to build a single extension module Previously we were building three different Python extension modules out of Rust space. This was convenient for logical s... push web-flow github
89.27
See All Builds (9023)