OpenTreeMap / otm-core

84%

develop: 84%

LAST BUILD ON BRANCH hotfix/2.21.2

branch: hotfix/2.21.2

CHANGE BRANCH

x

Reset

• hotfix/2.21.2
• master
• feature/jcw/comment-out-importer-support-for-read-only
• feature/jcw/show-import-update-date-rather-than-id
• feature/jcw/remove-gender-from-species
• release
• fix/jcw/fix-species-import-guide-link
• fix/jcw/remove-gender-fieldpermissions
• fix/jcw/remove-gender-fieldpermissions-2
• feature/jcw/add-favs-to-profile
• feature/jcw/speed-up-user-audit-query
• feature/jcw/speed-up-instance-edits-page
• feature/jcw/show-alt-no-favs-message
• fix/jcw/double-wrapped-api-species-view
• feature/jcw/mapfeature-updated-at
• fix/jcw/make-import-statuses-unique
• feature/jcw/new-modeling-header
• feature/mw/modeling-planlist
• feature/mw/scenario-protoype
• admin-styling
• remove-unused-provisioning-items
• gitter
• add-suppport-for-inline-translations-to-field-tags
• revert-2233-remove-unused-provisioning-items
• requires-io-master
• modular-pricing
• foo
• feature/mw/mgmt-cleanup
• feature/mw/highlight-color
• feature/mw/updated-spinner
• feature/mw/mgmt-padding-issue
• feature/mw/suspend-map-cleanup
• feature/mw/modal-warning
• feature/mw/multiselect-style-fix
• otm-cloud
• feature/mw/dashboard-style-cleanup
• feature/hmc/django-site-domain
• feature/mw/advanced-search-style
• feature/mw/new-field-highlight
• develop
• release-2.0
• requires-io-develop
• release/2.1.0
• 2.1.0
• hotfix/2.1.1
• 2.1.1
• feature/mw/plan-modal-labels
• revert-2483-feature/tune-rate-limiting
• revert-2485-revert-2483-feature/tune-rate-limiting
• release/2.2.0
• feature/hmc/statsd-celery
• release/2.3.0
• 2.3.0
• release/2.4.0
• 2.4.0
• release/2.5.0
• 2.5.0
• hotfix/2.5.1
• 2.5.1
• release/2.6.0
• 2.6.0
• bug/sml/admin-treemap-title-wrapping
• feature/mw/dashboard-header-fix
• feature/mw/global-spinner
• release/2.7.0
• 2.7.0
• feature/hmc/bump-pyrollbar
• release/2.8.0
• 2.8.0
• feature/sml/location-search-marker
• release/2.9.0
• 2.9.0
• kd/numeric-udf-validation
• feature/sml/profile-name-wrapping-bug
• feature/sml/management-sidebar-click-targets
• kd/restrict-polygonal-features
• kd/clear-boundary-polygon
• release/2.10.0
• 2.10.0
• udf-date-validation
• release/2.11.0
• 2.11.0
• hotfix/2.11.1
• 2.11.1
• maurizi-requires-io
• release/2.12.0
• 2.12.0
• feature/tnation/rollbar-upgrade
• feature/tnation/rollbar
• modeling-chart-labels-2
• modeling-mortality-params
• release/2.13.0
• feature/mw/modelling-cleanup
• 2.13.0
• feature/mw/modeling-btn-fix
• feature/mw/modeling-num-input-fixes
• feature/mw/modeling-toolbar-small-desktops-fix
• feature/mw/modeling-sidebar-toolbar-fixes
• hotfix/2.13.1
• 2.13.1
• release/2.14.0
• 2.14.0
• release/2.15.0
• kd/protected-udf
• kd/works-management
• kd/wmm-custom-fields
• list
• 2.15.0
• kd/sequential-reference-number
• kd/wm-task-priority
• kd/wm-teams
• rtb/no-polygon-on-mobile
• release/2.16.0
• rtb/fix-detail-search
• custom-field-mgmt-ui
• 2.16.0
• rtb/custom-field-reuse-fix
• rtb/stewardship-search-date-bug
• rtb/no-double-quotes
• rtb/defer-choice-delete
• rtb/default-static-pages
• split-modeling
• release/2.17.0
• rtb/hstore
• rtb/static-page-edit-default
• rtb/export-comments-button
• rtb/importer-proximity
• rtb/skipped-bioswale-test
• 2.17.0
• rtb/ecobenefits-totals
• jcw/fix-geocode-test
• hotfix/2.17.1
• 2.17.1
• update-python-deps-1.8
• release/2.19.0
• 2.19.0
• jw/units-fix
• hotfix/2.19.1
• jw/export-units-fix
• 2.19.1
• hotfix/2.19.2
• 2.19.2
• jcw/jquery-3
• jcw/js-deps
• jcw/fix-modeling-csv
• release/2.20.0
• 2.20.0
• otm-bryant2
• jcw/bryant3
• jcw/update-moment
• release/2.21.0
• jcw/fix-basemap-restore
• 2.21.0
• jcw/date-picker-bug
• jcw/fix-invitation-activation
• hotfix/2.21.1
• 2.21.1
• feature/hmc/omgeo-with-requests
• jcw/photo-export
• jcw/mobile-safari-layer-selector
• feature/hmc/remove-circle-ci
• 2.21.2
• hotfix/2.21.3
• jcw/handle-basemap-pref-not-available
• 2.21.3
• jcw/catch-basemap-crash
• jcw/fix-udf-helper
• hotfix/2.21.4
• jcw/fix-basemap-crash-hotfix
• jcw/udf-choice-whitespace
• jcw/dependency-updates
• 2.21.4
• hotfix/2.21.5
• jcw/delete-tree-with-hidden-id
• jcw/hidden-tree-id-can-be-shown
• 2.21.5
• hotfix/2.21.6
• jcw/tree-edit-perm
• jcw/update-urllib3
• 2.21.6
• jcw/registration-recaptcha
• hotfix/2.21.7
• 2.21.7
• release/2.22.0
• 2.22.0
• hotfix/2.22.1
• jcw/encode-geocode-param
• 2.22.1
• feature/hmc/remove-statsd
• feature/hmc/systemd-non-ascii-output
• dependabot/npm_and_yarn/lodash-4.17.13
• dependabot/pip/pillow-6.2.0
• jcw/update-djqscsv-and-tinsel
• dependabot/npm_and_yarn/fstream-1.0.12
• dependabot/npm_and_yarn/extend-3.0.2
• python3
• feature/provision-py3
• dependabot/pip/django-1.11.28
• dependabot/pip/django-1.11.29
• dependabot/npm_and_yarn/websocket-extensions-0.1.4
• dependabot/npm_and_yarn/lodash-4.17.19
• feature/jcw/api-docs-and-tool
• dependabot/npm_and_yarn/node-sass-4.13.1
• dependabot/npm_and_yarn/http-proxy-1.18.1
• dependabot/npm_and_yarn/ini-1.3.7
• hotfix/2.22.2
• dependabot/npm_and_yarn/y18n-3.2.2
• dependabot/npm_and_yarn/sockjs-0.3.21

Build # 3328

Build Type

push

travis-ci

Committed by jwalgran

Commit Message

Monkey patch the Leaflet layer selector to work in Mobile Safari

Tapping on the layers control in Mobile Safari was not opening the layer
selector. I was not able to reproduce this issue in a separate test application,
only within OTM.

After much trial and error I discovered that changing this line
  L.DomEvent.on(el, L.Draggable.START.join(' '), stop);
to
  L.DomEvent.on(container, 'mousedown', stop); in
DomEvent.disableClickPropagation resolved the issue. Effectively, this
prevents the `touchstart` event from being stopped.

I opted to implement this as a runtime patch applied within MapManager instead
of a global patch to the Leaflet source because there are no other Leaflet
behaviors that are known to be broken in Mobile Safari and I did not want to
risk introducing a regression in some other event handling.

I minimized the chance of forgetting about this patch if/when we upgrade our
version of Leaflet by adding a comment to package.json.

Run Details

18555 of 22143 relevant lines covered (83.8%)

0.84 hits per line