3328
84%
develop: 84%

Ran 01 Aug 2018 07:25PM UTC

Jobs 1

Files 235

Run time 43s

Badge

Embed ▾

pending completion

Build # 3328

Build Type

push

travis-ci

Committed by

jwalgran

Commit Message

Monkey patch the Leaflet layer selector to work in Mobile Safari

Tapping on the layers control in Mobile Safari was not opening the layer
selector. I was not able to reproduce this issue in a separate test application,
only within OTM.

After much trial and error I discovered that changing this line
  L.DomEvent.on(el, L.Draggable.START.join(' '), stop);
to
  L.DomEvent.on(container, 'mousedown', stop); in
DomEvent.disableClickPropagation resolved the issue. Effectively, this
prevents the `touchstart` event from being stopped.

I opted to implement this as a runtime patch applied within MapManager instead
of a global patch to the Leaflet source because there are no other Leaflet
behaviors that are known to be broken in Mobile Safari and I did not want to
risk introducing a regression in some other event handling.

I minimized the chance of forgetting about this patch if/when we upgrade our
version of Leaflet by adding a comment to package.json.

Run Details

18555 of 22143 relevant lines covered (83.8%)

0.84 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	3328.1	01 Aug 2018 07:25PM UTC	0	83.8	Travis Job 3328.1

Source Files on build 3328

Detailed source file information is not available for this build.

OpenTreeMap / otm-core / 3328
84%
develop: 84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3328

OpenTreeMap / otm-core / 3328 84% develop: 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3328

OpenTreeMap / otm-core / 3328
84%
develop: 84%

README BADGES
x