MobilityDB / MobilityDB
95%

DEFAULT BRANCH: master
Repo Added
Files 130
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

coverage: 95.217% (+0.005%) from 95.212%
23755778968

push

github

web-flow 
Enable using MeosArray beyond parsing (#768)

This commit moves the meos_array defintions from type_parser.c to
meos_internal.c to be available for other places in the codebase.
Additionally, we improve the API to be more uniform and easier to use.

Core changes to meos_array.c:
- meos_array_add: when varlength, store the pointer as a Datum instead
  of copying bytes from the address. Callers pass the pointer directly
  (e.g., meos_array_add(array, inst)) instead of wrapping in Datum.
- meos_array_get_n: return void * instead of Datum. For varlength arrays,
  return the stored pointer; for fixed-size arrays, return a pointer to
  the element in the internal buffer.
- meos_array_reset/destroy: add free_elems parameter. When true and the
  array is varlength, pfree each stored pointer. The array does not
  unconditionally free pointed-to memory; ownership is explicit.
- meos_array_destroy: fix memory leak by freeing array->elems.

Header changes:
- Move MeosArray typedef from public meos.h to meos_internal.h.
- Improve varlength field comment to clarify pointer storage semantics.

Caller updates (type_parser.c, tspatial_parser.c, trgeo_parser.c):
- Use meos_array_init(sizeof(Datum)) for set_parse (always stores Datums).
- Pass pointers directly to meos_array_add for temporal parsers.
- Replace DatumGetTInstantP/DatumGetTSequenceP with simple casts.
- Pass true to meos_array_destroy to free parsed objects on cleanup.

Co-authored-by: Maxime Schoemans <maxime.schoemans@enterprisedb.com>

90 of 97 new or added lines in 8 files covered. (92.78%)

32665 of 34306 relevant lines covered (95.22%)

1142066.22 hits per line

Relevant lines Covered
34306 RELEVANT LINES 32665 COVERED LINES
1142066.22 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
23755778968 master Enable using MeosArray beyond parsing (#768) This commit moves the meos_array defintions from type_parser.c to meos_internal.c to be available for other places in the codebase. Additionally, we improve the API to be more uniform and easier to use... push web-flow github
95.22
23606556697 master Clean up rtree_example (#774) Rewrite the example to run all four bounding box types (floatspan, tstzspan, tbox, stbox) sequentially at runtime instead of using compile-time #if/#elif blocks that required recompilation to switch types. Each type... push web-flow github
95.21
23605116895 master Uniformize distance functions to return DBL_MAX on error or empty geometries (#769) push web-flow github
95.21
23604848585 master Add rtree_insert_temporal and rtree_search_temporal convenience functions (#773) Add functions that automatically extract the bounding box from a Temporal value, so users don't need to manually call tnumber_to_tbox or tspatial_to_stbox before ins... push web-flow github
95.21
23604155451 master Add search operation support to R-tree (overlaps, contains, contained_by) (#772) Add RTreeSearchOp enum to the public API with three operations following the GiST naming convention (from the stored box's perspective): - RTREE_OVERLAPS: find store... push web-flow github
95.21
23602072690 master Fix R-tree bugs: node_choose containment, id type, allocator, stack buffer (#771) - node_choose() checked the root bounding box `&rtree->box` instead of the i-th child's bbox `RTREE_NODE_BBOX_N(node, i)`, causing all insertions to go into child 0... push web-flow github
95.21
23436891017 master Fix inverted geodetic flag in geoset_make (#765) ### Bug fix: `geoset_make` inverted geodetic flag `geoset_make` in `geoset_meos.c` had an inverted ternary for determining the set type. `FLAGS_GET_GEODETIC` is truthy when the geodetic flag is s... push web-flow github
95.21
23412165671 master Minor bug in numspanset_shift_scale (#763) (#764) ## Bug fix: numspanset_shift_scale haswidth is a bool — passing it instead of width (the actual Datum value) to ensure_positive_datum meant the width value was never validated correctly. This wou... push web-flow github
95.21
23411899629 master Fix error code in MEOS for division by zero (#761) push web-flow github
95.22
23411885808 master Fix tpoint_parse when erroneous input is detected (#759) push web-flow github
95.21
See All Builds (2351)