MobilityDB / MobilityDB / 23755778968

95%

push

github

Enable using MeosArray beyond parsing (#768)

This commit moves the meos_array defintions from type_parser.c to
meos_internal.c to be available for other places in the codebase.
Additionally, we improve the API to be more uniform and easier to use.

Core changes to meos_array.c:
- meos_array_add: when varlength, store the pointer as a Datum instead
  of copying bytes from the address. Callers pass the pointer directly
  (e.g., meos_array_add(array, inst)) instead of wrapping in Datum.
- meos_array_get_n: return void * instead of Datum. For varlength arrays,
  return the stored pointer; for fixed-size arrays, return a pointer to
  the element in the internal buffer.
- meos_array_reset/destroy: add free_elems parameter. When true and the
  array is varlength, pfree each stored pointer. The array does not
  unconditionally free pointed-to memory; ownership is explicit.
- meos_array_destroy: fix memory leak by freeing array->elems.

Header changes:
- Move MeosArray typedef from public meos.h to meos_internal.h.
- Improve varlength field comment to clarify pointer storage semantics.

Caller updates (type_parser.c, tspatial_parser.c, trgeo_parser.c):
- Use meos_array_init(sizeof(Datum)) for set_parse (always stores Datums).
- Pass pointers directly to meos_array_add for temporal parsers.
- Replace DatumGetTInstantP/DatumGetTSequenceP with simple casts.
- Pass true to meos_array_destroy to free parsed objects on cleanup.

Co-authored-by: Maxime Schoemans <maxime.schoemans@enterprisedb.com>

90 of 97 new or added lines in 8 files covered. (92.78%)

32665 of 34306 relevant lines covered (95.22%)

1142066.22 hits per line