MediaComem / biopocket-backend

88%

master: 92%

LAST BUILD ON BRANCH task-locations-crud

branch: task-locations-crud

CHANGE BRANCH

x

Reset

• task-locations-crud
• add-actions-route
• add-theme-and-action
• bbox-padding
• cors-origin
• data-utils
• database-diagram
• db-sync
• document-api-error
• email-fixture-whitespace-fix
• eslint
• github-pages
• images-and-action-impact
• master
• method-not-allowed
• query-builder
• serialize-bookshelf-collections
• sprint-1-discovering-biodiversity
• sprint-2-discovering-actions
• sprint-2-tmp
• sprint-3-engage-in-an-action
• start-e2e-npm-script
• story-103-scripts-documentation
• story-2-user-registration
• story-55-action-description
• story-56-view-themes
• task-85-autotest
• task-create-location-migration
• task-locations-bbox-filter
• task-locations-crud-create
• update-subscription
• upgrade
• user-registration
• v0.1.0
• v0.2.0
• v0.2.1

Build # 50

Build Type

push

travis-ci

Committed by AlphaHydrae

Commit Message

Implement (C)RUD for locations

The same validator is used for creating and updating a location. It has
been modified to support a partial update.

Additional improvements:

* 2 tests have been added to ensure that the correct errors are returned
  by the API when trying to create a location with no attributes (i.e.
  it should indicate which are the required fields).

* A small error has been fixed in the invalid properties creation test.
  The test attempted to produce two different errors on the `street`
  property (blank & required), when it should have been the `street` and
  the `city` properties.

* RAML traits in `server/api/index.raml` have been split into multiple
  files in the `server/api/raml/traits` directory. A similar structure
  has been put in place to define RAML types.

* Test fixtures in `server/spec/fixtures` have been documented.

* A bug has been fixed in `server/utils/bookshelf-returning.js`. It was
  attempting to to call Knex's `returning` method with the wrong
  arguments, using an array's items as the parameters rather than the
  array itself as a single parameter.

Story: TG-43

Run Details

270 of 366 branches covered (73.77%)

Branch coverage included in aggregate %.

1064 of 1144 relevant lines covered (93.01%)

14.17 hits per line