Matoking / protontricks

96%

master: 96%

LAST BUILD ON BRANCH fix-flatpak-discovery

branch: fix-flatpak-discovery

CHANGE BRANCH

x

Reset

• fix-flatpak-discovery
• 1.10.0
• 1.10.1
• 1.10.2
• 1.10.3
• 1.10.4
• 1.10.5
• 1.11.0
• 1.11.1
• 1.12.0
• 1.12.1
• 1.13.0
• 1.13.1
• 1.14.0
• 1.14.1
• 1.3
• 1.3.1
• 1.4
• 1.4.1
• 1.4.2
• 1.5.2
• 1.6.0
• 1.6.1
• 1.6.2
• 1.7.0
• 1.8.0
• 1.8.1
• 1.8.2
• 1.9.0
• 1.9.1
• 1.9.2
• account_name_lowercase
• add_alias
• add_developer_name
• add_env
• add_sniper
• add_steamos_check
• app_type
• appinfo_v29
• appmanifest_permission
• arg_autocomplete
• better_error_messages
• better_usage
• bundle_vdf
• cabextract_workaround
• case_insensitive_fs
• case_insensitive_library_discovery
• check_flatpak_permissions
• check_launcher_start
• ci_py310
• clean_imports
• cleanup
• cli-refactor
• compatdata_find
• config_vdf_parse_fix
• corrupted_vdf
• coverage_conf
• coveralls_fix
• debug_logging
• dep_fix
• detect_custom_icon
• detect_flatpak
• detect_xdg_perms
• disable_background_wineserver
• drop_python34
• duplicate_fix
• empty_toolmanifest
• env_fix
• error_dialog
• files_fix
• fix-changelog
• fix-double-prompt
• fix-winedlloverrides
• fix_app_icons
• fix_app_mapping_detection
• fix_appinfo
• fix_appmanifest
• fix_bwrap_launcher
• fix_default_proton
• fix_deprecated_socket
• fix_duplicate_logs
• fix_gui_error
• fix_help
• fix_icon_size
• fix_jpeg_convert
• fix_launch_rename
• fix_library_discovery
• fix_locale
• fix_nonsteam_shortcuts
• fix_proton_discovery
• fix_python35_ci
• fix_requirements
• fix_steamapps_discovery
• fix_wineserver_race
• fix_xauthority_crash
• flatpak
• flatpak_fix
• gasinvein-system-wide-ct
• github_actions
• grant-h-patch
• gui_by_default
• hide_proton
• ignore_empty_compatibilitytool
• ignore_permission
• ignore_remaining_vdf
• improve_bwrap_mounts
• improve_doc
• interoperable_flatpak
• keep_wineserver_alive
• launcher
• launcher_with_icons
• lenient_jpeg_parse
• less_hacky_sys_argv
• less_jargon
• list-all
• list_all_apps
• log_compatibilitytool
• log_more
• makefile
• master
• more_details
• mount-runtime-tool
• name_update
• naming_fix
• new_runtime_names
• nix_fix
• no_wine_launcher_poll
• non_proton_tool
• non_steam_apps
• pathlib
• pipx_readme
• pressure_vessel_launcher
• print_proton_versions
• promote_flatpak
• prompt_steam_dir
• proton-custom-vdf-fix
• python312
• python34
• python35
• python35_fix
• python39
• python_update
• re_debug
• readme_beta
• readme_update
• refactor_script
• remove_beta_message
• remove_install_wd
• remove_old_appinfo
• replicate_runtime
• required_app_check
• return_status
• revert_dbus
• runtime_dir_fix
• secure_ci
• set_winedlloverrides
• setup_cfg
• setupcfg_cleanup
• setuptools_scm
• shortcut_appid_test
• sonic2kk-master
• standalone_flatpak
• steam_find_fix
• steam_runtime_bwrap
• steam_runtime_scout
• steam_runtime_soldier
• support_python313
• support_python314
• support_snap
• test-new-python
• tests
• tobi-added-table-of-contents
• toc-format-change
• tolerate-missing-installdir
• tolerate_compatibilitytool_issues
• troubleshooting
• update-ci
• update_badge
• update_importlib
• update_issue_template
• update_license
• update_readme
• update_template
• use_steam_compat_data_path
• userconfig_name_fix
• v1_11_0
• v1_11_1
• v1_12_0
• v1_12_1
• v1_13_0
• v1_13_1
• v1_14_0
• v1_14_1
• validate_appstream
• vcs-browser
• vdf_all_lowercase
• vdf_error
• vdf_remove_fix
• warn_multiple_steam_dirs
• wine_bin_path
• wine_binary_link
• wine_launcher_log
• zenity_fix
• zenity_not_found

Build # 23455453798

Build Type

push

github

Committed by Matoking

Commit Message

Fix disabled Flatpak filesystem permission check

Return all found Steam library paths in `get_steam_lib_paths`, even
those not found in the filesystem.

Due to earlier refactoring, the function checked which directories were
accessible in the filesystem and only returned those. The return value
was used by `prompt_filesystem_access`; any paths were obviously
already accessible in the sandbox, meaning the function would never find
any inaccessible paths and prompt the user.

Also add new regression test that tests this behavior by running an
actual Protontricks command while mocking the Python FS call to hide the
directory. An existing unit test for the Flatpak permission check was
insufficient as it only tested the prompt check in isolation with a
hardcoded list of paths.

Fixes #472

Coverage Stats

12792 of 13260 relevant lines covered (96.47%)

0.96 hits per line