MITLibraries / dspace-submission-composer

96%

main: 95%

LAST BUILD ON BRANCH IN-1455-create-batch-for-base-workflow-update

branch: IN-1455-create-batch-for-base-workflow-update

CHANGE BRANCH

x

Reset

Sync Branches

• IN-1455-create-batch-for-base-workflow-update
• 1319-create-separate-folder-for-dspace-metadata
• IN-1095-simplecsv-workflow
• IN-1096-ocw-workflow
• IN-1097-wiley-workflow
• IN-1098-sccs-workflow
• IN-1099-aws-clients
• IN-1099-ses-and-sqs-clients
• IN-1099-ses-sqs-clients
• IN-1100-archivesspace-workflow
• IN-1101-base-workflow
• IN-1101-sqs-refactor
• IN-1103-reconcile-cli-command
• IN-1104-deposit-command
• IN-1105-finalize-command
• IN-1106-add-docs
• IN-1108-setup-app
• IN-1157-build-report-system
• IN-1158-revise-reconcile-method
• IN-1167-remove-demo-workflow
• IN-1172-improve-logging-for-submit-and-finalize-methods
• IN-1172-logging-for-finalize-methods
• IN-1173-create-reconcile-report
• IN-1174-create-submit-report
• IN-1176-opencourseware-subjects-field
• IN-1186-simplecsv-fix-item-identifiers
• IN-1227-update-dsc-to-use-s3-bucket
• IN-1235-set-sqs-output-queues
• IN-1236-rename-s3-bucket-env
• IN-1315-create-item-db-model
• IN-1316-update-reconcile-command-to-use-dynamodb
• IN-1317-submit-dynamodb
• IN-1318-update-finalize-command-to-use-dynamodb
• IN-1319-create-separate-folder-for-dspace-metadata
• IN-1320-consolidate-results-in-finalize-report
• IN-1323-improve-methods-for-processing-result-messages
• IN-1324-workflows-use-single-output-queue
• IN-1341-rename-env-var-for-item-submissions-table
• IN-1344-finalize-fix-args-when-getting-record-from-dynamodb
• IN-1352-add-sync-cli-command
• IN-1354-itemsubmission-class-update
• IN-1355-refactor-reconcile-for-itemsubmission
• IN-1356-update-submit
• IN-1357-finalize-refactor
• IN-1394-opencourseware-use-metadata-transformer
• IN-1408-reconcile-by-record
• IN-1409-repo-alignment
• IN-1428-opencourseware-contrib-department-field-method
• IN-1431-align-methods-for-retrieving-source-metadata
• IN-1432-cache-bitstreams-to-workflow
• IN-1433-define-record-level-reconcile-item-methods
• IN-1455-create-batch-for-base-workflow
• IN-1456-add-create-cli-command
• IN-1460-add-batch-creation-report
• IN-1460-refactor-reporting-modules
• IN-1511-ocw-prepare-batch-method-and-review
• IN-1512-report-on-failures-during-batch-creation
• INFRA-509-sccs-deposit-request
• dependabot/pip/boto3-1.35.76
• dependabot/pip/boto3-1.35.77
• dependabot/pip/boto3-1.35.78
• dependabot/pip/boto3-1.35.79
• dependabot/pip/boto3-1.35.80
• dependabot/pip/boto3-1.35.81
• dependabot/pip/boto3-1.35.82
• dependabot/pip/boto3-1.35.83
• dependabot/pip/boto3-1.35.84
• dependabot/pip/boto3-1.35.85
• dependabot/pip/boto3-1.35.86
• dependabot/pip/boto3-1.35.87
• dependabot/pip/boto3-1.35.88
• dependabot/pip/boto3-1.35.89
• dependabot/pip/boto3-1.35.90
• dependabot/pip/boto3-1.35.91
• dependabot/pip/boto3-1.35.92
• dependabot/pip/boto3-1.35.93
• dependabot/pip/boto3-1.35.94
• dependabot/pip/boto3-1.35.95
• dependabot/pip/boto3-1.35.96
• dependabot/pip/boto3-1.35.97
• dependabot/pip/boto3-1.35.98
• dependabot/pip/boto3-1.35.99
• dependabot/pip/boto3-1.36.0
• dependabot/pip/boto3-1.36.1
• dependabot/pip/boto3-1.36.10
• dependabot/pip/boto3-1.36.11
• dependabot/pip/boto3-1.36.12
• dependabot/pip/boto3-1.36.13
• dependabot/pip/boto3-1.36.14
• dependabot/pip/boto3-1.36.15
• dependabot/pip/boto3-1.36.16
• dependabot/pip/boto3-1.36.17
• dependabot/pip/boto3-1.36.18
• dependabot/pip/boto3-1.36.19
• dependabot/pip/boto3-1.36.2
• dependabot/pip/boto3-1.36.20
• dependabot/pip/boto3-1.36.21
• dependabot/pip/boto3-1.36.22
• dependabot/pip/boto3-1.36.23
• dependabot/pip/boto3-1.36.24
• dependabot/pip/boto3-1.36.25
• dependabot/pip/boto3-1.36.26
• dependabot/pip/boto3-1.36.3
• dependabot/pip/boto3-1.36.4
• dependabot/pip/boto3-1.36.5
• dependabot/pip/boto3-1.36.6
• dependabot/pip/boto3-1.36.7
• dependabot/pip/boto3-1.36.8
• dependabot/pip/boto3-1.36.9
• dependabot/pip/boto3-1.37.0
• dependabot/pip/boto3-1.37.1
• dependabot/pip/boto3-1.37.2
• dependabot/pip/boto3-1.37.3
• dependabot/pip/boto3-1.37.4
• dependabot/pip/boto3-stubs-1.35.76
• dependabot/pip/boto3-stubs-1.35.77
• dependabot/pip/boto3-stubs-1.35.78
• dependabot/pip/boto3-stubs-1.35.79
• dependabot/pip/boto3-stubs-1.35.80
• dependabot/pip/boto3-stubs-1.35.81
• dependabot/pip/boto3-stubs-1.35.82
• dependabot/pip/boto3-stubs-1.35.83
• dependabot/pip/boto3-stubs-1.35.84
• dependabot/pip/boto3-stubs-1.35.85
• dependabot/pip/boto3-stubs-1.35.86
• dependabot/pip/boto3-stubs-1.35.87
• dependabot/pip/boto3-stubs-1.35.88
• dependabot/pip/boto3-stubs-1.35.89
• dependabot/pip/boto3-stubs-1.35.90
• dependabot/pip/boto3-stubs-1.35.91
• dependabot/pip/boto3-stubs-1.35.92
• dependabot/pip/boto3-stubs-1.35.93
• dependabot/pip/boto3-stubs-1.35.94
• dependabot/pip/boto3-stubs-1.35.95
• dependabot/pip/boto3-stubs-1.35.96
• dependabot/pip/boto3-stubs-1.35.97
• dependabot/pip/boto3-stubs-1.35.98
• dependabot/pip/boto3-stubs-1.35.99
• dependabot/pip/boto3-stubs-1.36.0
• dependabot/pip/boto3-stubs-1.36.1
• dependabot/pip/boto3-stubs-1.36.10
• dependabot/pip/boto3-stubs-1.36.11
• dependabot/pip/boto3-stubs-1.36.12
• dependabot/pip/boto3-stubs-1.36.13
• dependabot/pip/boto3-stubs-1.36.14
• dependabot/pip/boto3-stubs-1.36.15
• dependabot/pip/boto3-stubs-1.36.16
• dependabot/pip/boto3-stubs-1.36.17
• dependabot/pip/boto3-stubs-1.36.18
• dependabot/pip/boto3-stubs-1.36.2
• dependabot/pip/boto3-stubs-1.36.21
• dependabot/pip/boto3-stubs-1.36.22
• dependabot/pip/boto3-stubs-1.36.23
• dependabot/pip/boto3-stubs-1.36.24
• dependabot/pip/boto3-stubs-1.36.25
• dependabot/pip/boto3-stubs-1.36.26
• dependabot/pip/boto3-stubs-1.36.3
• dependabot/pip/boto3-stubs-1.36.4
• dependabot/pip/boto3-stubs-1.36.5
• dependabot/pip/boto3-stubs-1.36.6
• dependabot/pip/boto3-stubs-1.36.7
• dependabot/pip/boto3-stubs-1.36.8
• dependabot/pip/boto3-stubs-1.36.9
• dependabot/pip/boto3-stubs-1.37.0
• dependabot/pip/boto3-stubs-1.37.1
• dependabot/pip/boto3-stubs-1.37.2
• dependabot/pip/boto3-stubs-1.37.3
• dependabot/pip/boto3-stubs-1.37.4
• dependabot/pip/cryptography-44.0.1
• dependabot/pip/jinja2-3.1.5
• dependabot/pip/moto-5.0.23
• dependabot/pip/moto-5.0.24
• dependabot/pip/moto-5.0.25
• dependabot/pip/moto-5.0.26
• dependabot/pip/moto-5.0.27
• dependabot/pip/moto-5.0.28
• dependabot/pip/mypy-1.14.0
• dependabot/pip/mypy-1.14.1
• dependabot/pip/mypy-1.15.0
• dependabot/pip/pre-commit-4.1.0
• dependabot/pip/pytest-8.3.4
• dependabot/pip/ruff-0.8.1
• dependabot/pip/ruff-0.8.2
• dependabot/pip/ruff-0.8.3
• dependabot/pip/ruff-0.8.4
• dependabot/pip/ruff-0.8.5
• dependabot/pip/ruff-0.8.6
• dependabot/pip/ruff-0.9.0
• dependabot/pip/ruff-0.9.1
• dependabot/pip/ruff-0.9.2
• dependabot/pip/ruff-0.9.3
• dependabot/pip/ruff-0.9.4
• dependabot/pip/ruff-0.9.5
• dependabot/pip/ruff-0.9.6
• dependabot/pip/ruff-0.9.7
• dependabot/pip/ruff-0.9.8
• dependabot/pip/ruff-0.9.9
• dependabot/pip/sentry-sdk-2.19.0
• dependabot/pip/sentry-sdk-2.19.1
• dependabot/pip/sentry-sdk-2.19.2
• dependabot/pip/sentry-sdk-2.20.0
• dependabot/pip/sentry-sdk-2.22.0
• infra-flow
• main
• ocw-mapping-fix
• refactor-cli-options
• support-for-dynamodb
• workaround

Build # 17986661872

Build Type

push

github

Committed by jonavellecuerdo

Commit Message

Refactor batch creation methods

Why these changes are being introduced:
It was decided that the batch creation step would assume
the responsibilities that were previously assigned to the
reconcile step, which is now up for deprecation.

How this addresses that need:
* Define shared private method for writing records to DynamoDB
* Define public abstract method for preparing a batch
* Define SimpleCSV.prepare_batch
* Add unit tests for batch creation methods

Side effects of this change:
* Sets the stage for deprecation of 'reconcile_items'

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1455

Run Details

25 of 35 new or added lines in 4 files covered. (71.43%)

8 existing lines in 2 files now uncovered.

1074 of 1121 relevant lines covered (95.81%)

0.96 hits per line