MITLibraries / dspace-submission-composer
96%
main: 95%

LAST BUILD BRANCH: ocw-mapping-fix
DEFAULT BRANCH: main
Repo Added
Token Is1ouZ3Mu7H6XOLn5MQ3NKDGwcSUnnTxZ regen
Build 511 Last
Files 18
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH IN-1355-refactor-reconcile-for-itemsubmission
branch: IN-1355-refactor-reconcile-for-itemsubmission
CHANGE BRANCH
x
Sync Branches

coverage: 96.447% (-0.4%) from 96.872%
16680805114

Pull #190

github

jonavellecuerdo 
Rework ItemSubmission to better encapsulate data persistence layer

Why these changes are being introduced:
* Initial work to update the 'reconcile' and 'submit' commands to use the refactored
ItemSubmission class underscored the need for additional updates to improve the
ergonomics of the class and emphasize the encapsulation of data persistance
as part of the domain model. While most of the code was already in place,
these updates focus on some renaming and slight reorganization of methods related
to database operations. The renames were intended to reflect that pulling data
from the DynamoDB table is an inherent part of creating an ItemSubmission.

How this addresses that need:
* Move logic for loading data into ItemSubmission into a private method ('_from_db')
* Rename 'update_db' -> 'upsert_db' to clarify insertion of new records
* Rework existing methods to get, get_batch, and create methods
* Update Workflow.reconcile_items to use get and create methods
* Update Workflow.submit_items to use get_batch to iterate over ItemSubmission
instances for a given batch

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1355
Pull Request #190: In 1355 refactor reconcile for itemsubmission

42 of 44 new or added lines in 4 files covered. (95.45%)

4 existing lines in 2 files now uncovered.

950 of 985 relevant lines covered (96.45%)

0.96 hits per line

Relevant lines Covered
985 RELEVANT LINES 950 COVERED LINES
0.96 HITS PER LINE
Source Files on IN-1355-refactor-reconcile-for-itemsubmission

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
16680805114 IN-1355-refactor-reconcile-for-itemsubmission Rework ItemSubmission to better encapsulate data persistence layer Why these changes are being introduced: * Initial work to update the 'reconcile' and 'submit' commands to use the refactored ItemSubmission class underscored the need for addition... Pull #190 jonavellecuerdo github
96.45
16680587924 IN-1355-refactor-reconcile-for-itemsubmission cleanup Pull #190 jonavellecuerdo github
96.73
16677289461 IN-1355-refactor-reconcile-for-itemsubmission Address comments in PR #190 * Clean up comment in Workflow.reconcile_items * Replace get_item_identifier method calls with indexing of item_metadata * Access item_submission.status when needed * Remove unneeded logging in Workflow.reconcile_items Pull #190 jonavellecuerdo github
96.73
16656257183 IN-1355-refactor-reconcile-for-itemsubmission Rename test module to match name of corresponding module Pull #190 jonavellecuerdo github
95.96
16656044984 IN-1355-refactor-reconcile-for-itemsubmission Rework ItemSubmission class to clearly demonstrate encapsulated data persistence layer Why these changes are being introduced: * Initial work to update the 'reconcile' and 'submit' commands to use the refactored ItemSubmission class underscored t... Pull #190 jonavellecuerdo github
95.96
16655994929 IN-1355-refactor-reconcile-for-itemsubmission Rework ItemSubmission class to clearly demonstrate encapsulated data persistence layer Why these changes are being introduced: * Initial work to update the 'reconcile' and 'submit' commands to use the refactored ItemSubmission class underscored t... push jonavellecuerdo github
95.96
16606864346 IN-1355-refactor-reconcile-for-itemsubmission Rework 'get_item_identifier' as final method on base Workflow Why these changes are being introduced: * Since all 'item_metadata_iter' methods are set to return metadata with the item identifying column explicitly named 'item_identifier', workflo... push jonavellecuerdo github
97.09
16601190609 IN-1355-refactor-reconcile-for-itemsubmission Include additional processing steps to SimpleCSV 'item_metadata_iter' Why these changes are being introduced: * This is to ensure that the item-identifying column is explicitly called 'item_identifier' when SimpleCSV.item_metadata_iter yields row... push jonavellecuerdo github
97.02
See All Builds (510)

Badge your Repo: dspace-submission-composer

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh