MITLibraries / carbon

98%

main: 93%

LAST BUILD ON BRANCH carbon-refactor-improvements

branch: carbon-refactor-improvements

CHANGE BRANCH

x

Reset

• carbon-refactor-improvements
• IN-1256-pip-audit
• IN-1333-article-feed-date-scoped
• IN-884-refactor-config-loading
• IN-885-app-stabilization-linters
• IN-885-app-stablization
• IN-886-use-new-data-warehouse-secret
• IN-887-use-new-symplectic-ftp-params
• IN-889-configure-sentry
• IN-905-refine-var-names-and-docstrings
• IN-906-include-engine-creation-in-main
• IN-907-define-feed-classes
• IN-908-build-dev-testing-framework
• IN-923-925-raise-exceptions-and-add-make-commands
• IN-924-fix-ftp-file-transfer-method
• IN-928-create-config-class
• IN-930-add-diagrams-to-readme
• aa-feed
• add-areas
• add-fields
• aws-cli-v2
• awsorg
• case
• certified
• cli
• cli-args
• command-help
• context
• coverage
• coveralls
• create-diagram
• dependabot/docker/python-3.12-slim
• dependabot/pip/boto3-1.28.25
• dependabot/pip/boto3-1.28.30
• dependabot/pip/boto3-1.28.32
• dependabot/pip/boto3-1.28.35
• dependabot/pip/boto3-1.28.40
• dependabot/pip/boto3-1.28.44
• dependabot/pip/boto3-1.28.49
• dependabot/pip/boto3-1.28.53
• dependabot/pip/boto3-1.28.57
• dependabot/pip/boto3-1.28.62
• dependabot/pip/boto3-1.28.63
• dependabot/pip/boto3-1.28.68
• dependabot/pip/boto3-1.28.73
• dependabot/pip/boto3-1.33.11
• dependabot/pip/boto3-1.33.6
• dependabot/pip/boto3-1.34.11
• dependabot/pip/boto3-1.34.2
• dependabot/pip/boto3-1.34.7
• dependabot/pip/boto3-stubs-1.28.25
• dependabot/pip/boto3-stubs-1.28.30
• dependabot/pip/boto3-stubs-1.28.32
• dependabot/pip/boto3-stubs-1.28.35
• dependabot/pip/boto3-stubs-1.28.40
• dependabot/pip/boto3-stubs-1.28.44
• dependabot/pip/boto3-stubs-1.28.49
• dependabot/pip/boto3-stubs-1.28.53
• dependabot/pip/boto3-stubs-1.28.57
• dependabot/pip/boto3-stubs-1.28.62
• dependabot/pip/boto3-stubs-1.28.63
• dependabot/pip/boto3-stubs-1.28.68
• dependabot/pip/boto3-stubs-1.28.73
• dependabot/pip/boto3-stubs-1.33.11
• dependabot/pip/boto3-stubs-1.33.6
• dependabot/pip/boto3-stubs-1.34.11
• dependabot/pip/boto3-stubs-1.34.2
• dependabot/pip/boto3-stubs-1.34.7
• dependabot/pip/cryptography-3.2
• dependabot/pip/cryptography-41.0.4
• dependabot/pip/cryptography-41.0.6
• dependabot/pip/lxml-4.6.2
• dependabot/pip/lxml-4.6.3
• dependabot/pip/moto-4.2.0
• dependabot/pip/moto-4.2.10
• dependabot/pip/moto-4.2.11
• dependabot/pip/moto-4.2.12
• dependabot/pip/moto-4.2.2
• dependabot/pip/moto-4.2.3
• dependabot/pip/moto-4.2.4
• dependabot/pip/moto-4.2.5
• dependabot/pip/moto-4.2.6
• dependabot/pip/moto-4.2.7
• dependabot/pip/moto-4.2.8
• dependabot/pip/moto-4.2.9
• dependabot/pip/mypy-1.6.0
• dependabot/pip/mypy-1.6.1
• dependabot/pip/mypy-1.7.1
• dependabot/pip/mypy-1.8.0
• dependabot/pip/py-1.10.0
• dependabot/pip/pyyaml-5.4
• dependabot/pip/sentry-sdk-1.32.0
• dependabot/pip/sentry-sdk-1.38.0
• dependabot/pip/sentry-sdk-1.39.1
• dependabot/pip/types-setuptools-68.1.0.0
• dependabot/pip/urllib3-1.25.8
• dependabot/pip/urllib3-1.26.17
• dependabot/pip/urllib3-1.26.18
• dependabot/pip/werkzeug-3.0.1
• deploy-bucket
• deps
• deps-upgrade
• docker
• docs
• env-docs
• fargate
• field-fixes
• fix-area
• fix-release
• fix-secrets
• fixtures
• flake8
• ftp
• github-actions
• groups
• hire-date
• in-622-stage-deploy
• infra-299-add-to-faculty-date
• lambda
• lambda-package
• leave-dates
• ll-employees
• main
• maintenace-week-07-2024
• maintenance-week-07-2024
• make-help
• make-publish-fix
• makefile
• makefile-fix
• master
• mem-db
• multifeeds
• names
• orcids
• poc-maintainer-links
• post-xml
• readme
• rebuild
• refs/tags/v3.0.0
• remove-old
• req_fields
• secret-id
• ssl-session
• start-date-2
• stream-xml
• timeout
• unicle
• update_sql
• v1.1.0
• v1.2.0
• v2.0.0
• v3.1.0

Build # 6003960121

Build Type

push

github

Committed by jonavellecuerdo

Commit Message

IN-X Include creation of DatabaseEngine as part of CLI main

Why these changes are being introduced:
* This change contributes to improved code readability and cohesion as it
results in all method calls being executed through the CLI's main function.

How this addresses that need:
* Removing engine creation from db.py
* Creating an instance of DatabaseEngine in cli.py
* Adding the engine as a parameter to classes and methods in app.py
* Update tests

Side effects of this change:
* None

Relevant ticket(s):
* X

Run Details

13 of 13 new or added lines in 2 files covered. (100.0%)

285 of 290 relevant lines covered (98.28%)

0.98 hits per line