Knio / dominate

100%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 2.2.1
• 2.3.0
• 2.3.1
• 2.3.5
• 2.4.0
• 2.5.0
• 2.5.1
• 2.5.2
• 2.6.0
• 2.7.0
• 3.0
• 3.1.0
• add-3.14
• codex/delete-child-index
• feat/preserve-inline-link-whitespace
• fix-child-task-dom-context-20261011
• fix-unescape-large-entity-crash
• fix/attr-clean-pair
• fix/preserve-zero-attributes
• fix/render-lazy-nodes-directly
• knio
• knio/py39
• master
• py35
• replace_get_event_loop
• test
• washad-master

Build # 41536056036

Build Type

push

github

Committed by web-flow

Commit Message

Use the tag's attribute cleaning in attr() and dict attributes (#237)

* Test attr() and dict attributes on SVG tags

* Use the tag's attribute cleaning in attr() and dict attributes

Keyword arguments to a tag are cleaned with type(self).clean_pair, so a
subclass's clean_attribute applies (e.g. svg_tag turns stroke_width into
stroke-width). attr() and dicts passed to add() called dom_tag.clean_pair
instead, so with circle(): attr(stroke_width=2) and
circle({'stroke_width': 2}) rendered stroke_width="2".

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

792 of 792 relevant lines covered (100.0%)

7.0 hits per line