Khan / aphrodite

0%

master: 0%

LAST BUILD ON BRANCH hash-length-perf

branch: hash-length-perf

CHANGE BRANCH

x

Reset

• hash-length-perf
• Set
• code-splitting
• coverage
• flow
• flushtostyletag
• jsdom
• keyframes-test
• mapobj
• master
• media-queries
• optimize-generateCSSRuleset
• rollup
• server-test-minification
• some-optimizations
• update-deps
• v1.2.1
• v1.2.2
• v1.2.3
• v1.2.4
• v1.2.5
• v2.0.0
• v2.1.0
• v2.1.1
• v2.2.0
• v2.2.1
• v2.2.2
• v2.2.3

Build # 484

Build Type

push

travis-ci

Committed by lencioni

Commit Message

Remove separate iteration for summing length of style defs

I've been profiling and noticed that injectAndGetClassName is a very hot
path so I've been thinking about ways to make it more efficient. I
noticed that we were iterating over things twice unnecessarily, so I've
moved a reduce function inline with our original iteration. This
improves my naive benchmark from ~2.94s to ~2.77s.

While I was at it, I removed an unnecessary object creation here, to hlp
improve efficiency and reduce the memory footprint.

I think it might be possible to further improve perf here by converting
the recursive function into an interative one, which I'm going to dig
into next.

Run Details

0 of 0 relevant lines covered (NaN%)

0.0 hits per line