Khan / aphrodite

0%

master: 0%

LAST BUILD ON BRANCH code-splitting

branch: code-splitting

CHANGE BRANCH

x

Reset

• code-splitting
• Set
• coverage
• flow
• flushtostyletag
• hash-length-perf
• jsdom
• keyframes-test
• mapobj
• master
• media-queries
• optimize-generateCSSRuleset
• rollup
• server-test-minification
• some-optimizations
• update-deps
• v1.2.1
• v1.2.2
• v1.2.3
• v1.2.4
• v1.2.5
• v2.0.0
• v2.1.0
• v2.1.1
• v2.2.0
• v2.2.1
• v2.2.2
• v2.2.3

Build # 516

Build Type

push

travis-ci

Committed by lencioni

Commit Message

Use code splitting for default and no-important builds

If two copies of Aphrodite end up being run at the same time, you can
easily encounter issues due to state stored by Aphrodite not being
shared between the multiple copies (e.g. `isBuffering`).

Since v2, when we started using rollup to build Aphrodite, this was
pretty easy to accidentally do if you weren't careful about when you
imported from `aphrodite` or `aphrodite/no-important`. This has resulted
in some issues, particularly around
react-with-styles-interface-amp-aphrodite and hypernova-amp not being
super careful about which version of aphrodite they import. One of the
recent fixes for this can be seen here:

  https://github.com/airbnb/react-with-styles-interface-amp-aphrodite/pull/8

In an effort to make this safer, I am making a small change to how we
build this library. Rollup offers an experimental code splitting mode
that allows us to keep the separate entry points and automatically
dedupe all of the shared code into a single chunk that each entry point
imports. As a result, we can provide the same API we currently do to
consumers, and avoid this issue to some extent.

The result of running this build on the es directory looks like the
following:

- chunk-957f2f88.js
- index.js
- no-important.js

and es/index.js ends up looking like:

```js
import { a as makeExports } from './chunk-957f2f88.js';
import 'string-hash';
import 'inline-style-prefixer/static/plugins/calc';
import 'inline-style-prefixer/static/plugins/crossFade';
import 'inline-style-prefixer/static/plugins/cursor';
import 'inline-style-prefixer/static/plugins/filter';
import 'inline-style-prefixer/static/plugins/flex';
import 'inline-style-prefixer/static/plugins/flexboxIE';
import 'inline-style-prefixer/static/plugins/flexboxOld';
import 'inline-style-prefixer/static/plugins/gradient';
import 'inline-style-prefixer/static/plugins/imageSet';
import 'inline-style-prefixer/static/plugins/position';
import 'inline-style-prefi... (continued)

Run Details

0 of 0 relevant lines covered (NaN%)

0.0 hits per line