ICRAR / daliuge

81%

master: 81%

LAST BUILD ON BRANCH yan-974

branch: yan-974

CHANGE BRANCH

x

Reset

• yan-974
• 2022-03-doxygen-fixes
• 406
• DLG_DockerDeploy
• DLG_PyPI_Deployment
• DropPython39
• EAGLE_FixMissingHelloWorldInputPort
• FixPyDataIssues_Again
• FixTestRunnerMixup
• LIU-103
• LIU-116-docker-drops
• LIU-116-dockerservice-drops
• LIU-116-enddrop
• LIU-116-service-drops
• LIU-117-plasmaflight
• LIU-128
• LIU-182
• LIU-186
• LIU-198
• LIU-213
• LIU-213-doxygen
• LIU-216
• LIU-251
• LIU-251-app-params
• LIU-251-extra
• LIU-251-pyfunc-simplify
• LIU-251-rebase
• LIU-253
• LIU-271
• LIU-276
• LIU-280
• LIU-280-Docs
• LIU-284
• LIU-285
• LIU-3
• LIU-303
• LIU-306
• LIU-318
• LIU-368
• LIU-368-AddServicesToAllowPersistence
• LIU-375_SupportInputNamedPortsForFile
• LIU-382
• LIU-383
• LIU-383_DangerousDefaults
• LIU-383_Warnings
• LIU-385
• LIU-385_SubGraphDrops
• LIU-388_UpdatePGGenTests
• LIU-392
• LIU-395
• LIU-396
• LIU-396-Tests
• LIU-401
• LIU-402
• LIU-403
• LIU-404
• LIU-406
• LIU-407
• LIU-408
• LIU-412
• LIU-413
• LIU-414
• LIU-416
• LIU-417
• LIU-42
• LIU-420
• LIU-423
• LIU-427
• LIU-438
• LIU-439
• LIU-444
• LIU-445
• LIU-448
• LIU-451
• LIU-454
• LIU-455
• LIU-457
• LIU-458
• LIU-460
• LIU-469
• LIU-470
• LIU-470_Fix
• LIU-472
• LIU-481
• LIU-486
• LIU-497
• LIU-499
• LIU-5
• LIU-502
• LIU-505
• LIU-505_branch-patch
• LIU-508
• LIU-510
• LIU-512
• LIU-514
• LIU-515
• LIU-516
• LIU-517
• LIU-522
• LIU-523
• LIU-525
• LIU-526
• LIU-527
• LIU-528
• LIU-529
• LIU-530
• LIU-531
• LIU-65
• LIU-67
• LIU-68
• LIU-74
• LIU-82
• LIU-86
• LIU-93
• LIU-96
• LIU390-RemovePlasmaAndPyArrow
• Makefile_fix
• OoD-Cld
• S3drop
• TerminateGraphOnRequest-8.3
• UpdateTestGraphVersion
• YAN-351_Installation
• YAN-678
• YAN-708
• YAN-853
• YAN-858
• YAN-882-gather
• YAN-882-plasmaflight
• YAN-913
• YAN-913-async-exec
• YAN-913-casacore
• YAN-913-casacore-testing
• YAN-913-rebase
• YAN-913-streaming
• YAN-969-docs
• additions
• adjust-build-replicate
• argparse
• autodoc_fix
• avahi-trans-fix
• bash-port-values
• branch_named_ports
• bugfix-unpartitioned-graph-labels
• cgray_dependencies
• create-missing-workdir
• cuda_deploy
• cwl-27-fixes
• daliuge-187
• dead-code
• debug-py27-error
• delayed
• delayed_fixes
• dependabot/pip/daliuge-common/pydantic-1.10.13
• devall-docker
• docker_fix
• docs-cleanup
• docs_fix-missing-install
• docs_update
• documentation-fix
• doxygentest
• eagle-1137
• eagle-1184
• eagle-1194
• eagle-121
• eagle-1231
• eagle-1231-2
• eagle-1269
• eagle-211
• eagle-273
• eagle-350
• eagle-402
• eagle-505
• eagle-535
• eagle-550
• eagle-614
• eagle-651
• eagle-828
• eagle-869
• eagle-869-2
• eagle-979
• eagle-991
• eagle-991-2
• eagle-pi-schema-update
• engine-web-ui
• feature/export-cwl
• feature/graph-updater-4
• feature/lgweb-post-lg
• feature/node-attributes
• features/liu-16
• fix-3.9-crashes
• fix-broken-expansion
• fix-dlg-submit
• fix-indexerror
• fix_cors_issue
• fix_objects
• fix_positional_arguments
• fix_readme_and_docs
• fix_server_genpgt_nodelist
• github-actions
• graph-enabler
• graph_fixes
• inspection
• latest-fixes
• lazy-logging-formatting
• lg-fill
• lg-refactor
• lg-web-echart
• lg-web-ui
• lg_web-graph-downloads
• liu-101
• liu-102
• liu-104
• liu-111
• liu-120
• liu-121
• liu-123
• liu-124
• liu-125
• liu-126
• liu-150
• liu-153
• liu-155
• liu-163
• liu-168
• liu-169
• liu-169-2
• liu-171
• liu-173
• liu-184
• liu-186-2
• liu-186-post-changes
• liu-189
• liu-193
• liu-194
• liu-195
• liu-205
• liu-207
• liu-216
• liu-220
• liu-221
• liu-222
• liu-226
• liu-227
• liu-228
• liu-232
• liu-233
• liu-234
• liu-235
• liu-236
• liu-247
• liu-248
• liu-249
• liu-256
• liu-257
• liu-261
• liu-262-data-component-default-ports
• liu-264
• liu-265
• liu-272
• liu-277
• liu-28
• liu-281
• liu-282
• liu-284-log-uncaught-exceptions
• liu-286
• liu-29
• liu-290
• liu-291
• liu-294
• liu-296
• liu-304
• liu-308-persist-flag
• liu-314
• liu-322-top-level-catch
• liu-332
• liu-338
• liu-343
• liu-343-mkn
• liu-345
• liu-348
• liu-349
• liu-353
• liu-354
• liu-355
• liu-361
• liu-365
• liu-367
• liu-377
• liu-418
• liu-449
• liu-456
• liu-51
• liu-53-docker-working-dir
• liu-532
• liu-533
• liu-66
• liu-67
• liu-68
• liu-87
• liu-90
• logging-improvements
• lui-189
• mab-ood-cld
• manager-termination
• master
• mergeIssues
• messaging-consolidation
• messaging-consolidation-take2
• minor-component-updates
• move-io
• mpi_fixes
• ms-mpi
• multiproc-drop-apps
• multiproc-drop-apps-julian
• name_fix
• named-ports
• new-slim
• ngasLite_mods
• nm-web-fix
• node-experiments
• ood-cld
• openapi
• openapi-tests-fix
• patch-daemon-tests
• patch_UpdateNamedPortConditional
• patch_urllib3_update
• pg-generator-refactor
• pin-pyarrow
• plasma
• plasmaflight-fixes
• popArg-refactor
• pre-0.6.1
• pyfunc_code
• python3-only
• pyzmq-lock
• ray_test
• rbunney_mpi_fixes
• remove-logspam-from-testrunner
• remove_parset_duplicates
• removing-lgweb
• reprocleanup
• reuseWindow
• revert-321-LIU-469
• ryan_mpi_fixes
• schema-compliance-fix
• separate-packages
• session_status_html_update
• simple-translator
• skip-mp-tests
• skip-zmq-resubscriptions
• slurm-remote
• speedup-remove-unmet-dependencies
• split-translator
• streaming-consumer-fix
• summit-latest
• test_daemon_issues
• test_python3.13
• travis-fix
• travis-fixes
• triggering-fix
• update-posargs-graphenabler
• v0.5.0
• v0.5.1
• v0.5.2
• v0.5.3
• v0.6.0
• v0.6.1
• v0.6.3
• v0.7.0
• v1.0.0
• v2.0.0
• v2.0.1
• v2.1.0
• v2.2.0
• v2.2.1
• v2.3.0
• v2.4.0
• v3.0.0
• v4.0.0
• v4.0.1
• v4.3.0
• v4.4.0
• v4.4.1
• v4.5.0
• v4.6.0
• v4.7.0
• v4.7.1
• v4.7.2
• v4.7.3
• v4.8.0
• v4.9.0
• v5.0.0
• v5.1.0
• v5.2.0
• v6.0.0
• v6.0.0_AutoDirectoryDropNaming
• v6.0.0_SupportDirectoryDropNaming
• validate-graphs
• warnings-off
• yaml-dependency-fixes
• yan-1048-remove-memory-leaks
• yan-1069
• yan-1070
• yan-17
• yan-334
• yan-424
• yan-425
• yan-539
• yan-667
• yan-759
• yan-763
• yan-763-docs
• yan-764
• yan-800
• yan-800-2
• yan-812
• yan-812-2
• yan-839
• yan-846
• yan-850
• yan-852
• yan-854
• yan-859
• yan-891
• yan-893
• yan-894
• yan-895
• yan-899-always-validate-lgs
• yan-919
• yan-922
• yan-927
• yan-931
• yan-945
• yan-959
• yan-968
• yan-968-rtobar
• yan-970
• yan-973
• yan-973-nifty-testing
• yan-973-rebase
• yan-975
• yan-976-constrain-resource-overusage
• yan-981-improve-dlg-logging
• yan-999
• yan919-docspatch-1

Build # 2085

Build Type

push

travis-ci-com

Committed by rtobar

Commit Message

Remove duplicated test code from test_dm

The TestDM and TestDMParallel classes were almost identical copies of
each other (with the former being the "source" of the latter, since it
was the one that existed first), with two main differences: firstly,
TestDM has an additional test_run_invalid_shmem_graph test; and
secondly, the number of threads they use to start the NMs in their tests
is different, with TestDM always using the default (0), and
TestDMParallel using the number of available CPUs, with some small
alterations.

Instead of copying the whole body of the tests, it's better from
a maintainability point of view if we avoid this code duplication, and
instead reuse the same code for both tests. This commit does exactly
that: it creates a NodeManagerTestsBase class with all the common test
definitions, and relying on self.nm_threads being defined later on, and
then subclass it with TestDM and TestDMParallel, each of which provides
its own self.nm_threads definition. In addition, TestDM contains its own
additional test.

This work is part of YAN-974.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

11 of 11 new or added lines in 1 file covered. (100.0%)

12372 of 15254 relevant lines covered (81.11%)

1.65 hits per line