ICRAR / daliuge
75%
master: 82%

LAST BUILD BRANCH: LIU-514
DEFAULT BRANCH: master
Repo Added
Files 196
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH skip-zmq-resubscriptions
branch: skip-zmq-resubscriptions
CHANGE BRANCH
x

615

api

travis-ci-com

rtobar 
Skip connection monitoring for connected endpoints

In 67b58ac we introduced a mechanism through which we ensure an actual
connection is made when setting up a subscription from a SUBSCRIBE
socket in order to avoid missing incoming events. While this first
implementation worked as intended, it didn't take into account the use
case when a second session/graph is deployed over existing, already
connected node managers; in those cases the system would try to issue a
new subscription through the SUBSCRIBE socket but without activity
happening on the corresponding monitor socket (a connection is
never made because it already exists). This in turn means that the
threading Event used to alert the caller about the connecting being
ready is never set, leading in turn to an error raised on the caller
side alerting about the situation.

This commit adds support for keeping track of the endpoints the
SUBSCRIBE socket is already connected to. This information is used to
then simply skip re-subscription to these endpoints, quickly letting the
caller know that the subscription is established.

A new unit test (for which existing infrastructure had to be slightly
adjusted) showcases the scenario (starts two successive sessions on the
same set of node managers). This is representative of the original
problem, and will ensure it doesn't happen in the future.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

8 of 8 new or added lines in 1 file covered. (100.0%)

6922 of 9182 relevant lines covered (75.39%)

3.8 hits per line

Relevant lines Covered
9182 RELEVANT LINES 6922 COVERED LINES
3.8 HITS PER LINE
Source Files on skip-zmq-resubscriptions

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
615 skip-zmq-resubscriptions Skip connection monitoring for connected endpoints In 67b58ac we introduced a mechanism through which we ensure an actual connection is made when setting up a subscription from a SUBSCRIBE socket in order to avoid missing incoming events. While t... api rtobar travis-ci-com pending completion  
See All Builds (3107)