HicServices / RDMP
57%

DEFAULT BRANCH: develop
Repo Added
Files 1157
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH develop
branch: SELECT
CHANGE BRANCH
x

coverage: 57.104%. Remained the same
26280563841

push

github

web-flow 
Cohort Builder: inject joinable knowledge after partial-refresh rebuild (#2335)

* Cohort Builder: inject joinable knowledge after partial-refresh rebuild

After a partial refresh that calls BuildAggregateConfigurations() (e.g.
SelectiveRefresh on a CohortAggregateContainer, fired on container
rename / move), every AggregateConfiguration in AllAggregateConfigurations
is replaced with a fresh DB-fetched instance.  These fresh instances
have their JoinableCohortAggregateConfiguration Lazy initialised to the
default DB-fetching variant.

Any subsequent enumeration that calls IsJoinablePatientIndexTable() then
triggers one Repository.GetAllObjectsWithParent<...>(this) round-trip
per AggregateConfiguration.  At HIC scale this manifests as a >7 second
freeze when constructing the cohort builder's right-click context menu,
because ExecuteCommandAddAggregateConfigurationToCohortIdentificationSetContainer's
constructor filters AllAggregateConfigurations by IsJoinablePatientIndexTable.

The main CatalogueChildProvider constructor already does this injection
explicitly (see "joinableDictionaryByAggregateConfigurationId" block
~line 441), with the comment "We can inject this knowledge now so to
avoid database lookups later".  The partial-refresh path was missing
the same step.

Fix: at the end of BuildAggregateConfigurations(), re-inject the joinable
knowledge from AllJoinables if it has already been populated by a prior
full rebuild.  No-op on the very first call (main constructor) where
AllJoinables is still null at this point — the existing explicit
injection block handles that case.

Measured impact on a HIC-scale platform database: container rename
freeze drops from ~10.4s to expected ~1.5-2s (saves the ~7s of
N×DB-queries from the menu rebuild).  No behavioural change otherwise;
the in-memory result is identical to what the main constructor's
explicit injection produces.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Update CHANGEL... (continued)

11554 of 21769 branches covered (53.08%)

Branch coverage included in aggregate %.

1 of 4 new or added lines in 1 file covered. (25.0%)

2 existing lines in 1 file now uncovered.

32679 of 55691 relevant lines covered (58.68%)

18115.09 hits per line

Relevant lines Covered
55691 RELEVANT LINES 32679 COVERED LINES
18115.09 HITS PER LINE
Source Files on develop

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26280563841 develop Cohort Builder: inject joinable knowledge after partial-refresh rebuild (#2335) * Cohort Builder: inject joinable knowledge after partial-refresh rebuild After a partial refresh that calls BuildAggregateConfigurations() (e.g. SelectiveRefresh on... push web-flow github
57.1
26280548007 develop Cohort Builder: partial-refresh AggregateConfiguration renames/moves (#2336) Adds AggregateConfiguration to the SelectiveRefresh type switch in CatalogueChildProvider.SelectiveRefresh(IMapsDirectlyToDatabaseTable). Previously this type fell throu... push web-flow github
57.1
26280220419 task/rdmp-378-extraction-pk-parity add merge pk parity push JFriel github
57.05
26279486554 task/rdmp-378-extraction-pk-parity add archive trigger view push JFriel github
57.06
26221529909 task/rdmp-378-extraction-pk-parity add pk parity check push JFriel github
57.13
26215279476 bugfix/cohort-commit-issue tidy up Pull #2333 JFriel github
57.13
26214064445 bugfix/cohort-commit-issue improved add push JFriel github
57.13
26213500438 bugfix/cohort-commit-issue improve inter-project cohort building push JFriel github
57.13
26213514786 bugfix/cohort-commit-issue update version push JFriel github
57.13
26173068416 bugfix/cohort-commit-issue update change tracking script Pull #2333 JFriel github
57.13
See All Builds (5809)