Freegle / iznik-server

86%

master: 88%

LAST BUILD ON BRANCH fix/push-notifications-test

branch: fix/push-notifications-test

CHANGE BRANCH

x

Reset

• fix/push-notifications-test
• better-phpunit
• feature/incoming-email-migration
• feature/notification-channels
• feature/remove-chat-notifications-migrated-to-laravel
• finnbarr-playwright
• fix-illustrations-infinite-loop
• fix/job-ads-layout
• fix/noreply-email-not-flagged
• master
• notification-seen-v2
• phpunit-parallel-workaround
• sentry-auto-fix-1763673463470
• sentry-auto-fix-1763674873674
• sentry-auto-fix-1763675166351
• sentry-auto-fix-1764010648194
• sentry-auto-fix-1764068461540
• sentry-auto-fix-1764072993817
• sentry-auto-fix-1764074565542
• unskip-tests

Build # #2588

Build Type

push

Committed by edwh

Commit Message

fix: Prevent PushNotificationsTest subscription deletion during chat creation

ChatMessage::create() with $process=TRUE triggers notifyMembers() which calls
real PushNotifications::notify() -> executeSend(). When the send fails (no valid
Firebase token in test), executeSend() deletes the subscription as cleanup,
causing testBasic() to fail when notifyGroupMods() later finds no subscription.

Fix: Pass $process=FALSE and manually mark the message as processed, matching
the pattern used elsewhere in this test file.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

25588 of 29833 relevant lines covered (85.77%)

30.7 hits per line