Freegle / Iznik
72%
master: 72%

LAST BUILD BRANCH: feat/nearby-towns-under-distance-slider
DEFAULT BRANCH: master
Repo Added
Files 1399
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perf/markseen-batch
branch: perf/markseen-batch
CHANGE BRANCH
x

coverage: 71.793% (-0.7%) from 72.492%
24904

Pull #958

circleci

edwh 
perf(markseen): batch the "mark seen" inserts (Galera-safe) instead of one INSERT per post

"Mark seen" on Browse ran one INSERT ... ON DUPLICATE KEY UPDATE per message id, so it scaled
linearly with the unread count - one DB round-trip per post. Batch the inserts into multi-row
statements (chunk 100): a mark-seen of N posts is now ~ceil(N/100) round-trips. Per-message
semantics are unchanged (ON DUPLICATE KEY UPDATE is per conflicting row).

Galera (Percona XtraDB Cluster) safety - a multi-row INSERT is one transaction, so a
certification conflict rolls back the whole statement (unlike the old per-row loop):
- Moderate chunk (100) bounds the rollback blast radius and lock footprint.
- Sort + de-dupe the ids so concurrent same-user mark-seens lock rows in a consistent order
  (no deadlock from opposite orderings) and a repeated id can't collide with itself in one
  statement.
- database.RetryExec retries transient connection/WSREP errors.
- Per-row fallback on deadlock/lock-timeout: a conflicting chunk degrades to per-row inserts
  (each its own tiny autocommit txn, the old behaviour) so the rest still land.

Follow-up (separate, larger): make mark-seen O(1) via a per-user, per-view high-water mark and
move the per-item View writes (needed for view-counts, dedup, the rippling underexposure score)
to the background_tasks queue.

Go suite green (3385/0): new TestMessagesMarkSeenBatchPreservesSemantics + TestDedupeSortedIDs;
existing markseen tests unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014ZeG2zmg2JCR8pYEjAUaAk
Pull Request #958: perf(markseen): batch "mark seen" inserts (Galera-safe) so it stops scaling per post

12353 of 16327 branches covered (75.66%)

Branch coverage included in aggregate %.

53 of 59 new or added lines in 1 file covered. (89.83%)

131262 of 183713 relevant lines covered (71.45%)

38.09 hits per line

Relevant lines Covered
183713 RELEVANT LINES 131262 COVERED LINES
38.09 HITS PER LINE
Source Files on perf/markseen-batch

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24904 perf/markseen-batch perf(markseen): batch the "mark seen" inserts (Galera-safe) instead of one INSERT per post "Mark seen" on Browse ran one INSERT ... ON DUPLICATE KEY UPDATE per message id, so it scaled linearly with the unread count - one DB round-trip per post. ... Pull #958 edwh circleci
71.79
See All Builds (1762)