Freegle / Iznik

72%

master: 70%

LAST BUILD ON BRANCH fix/external-da-pointer-events-block-clicks

branch: fix/external-da-pointer-events-block-clicks

CHANGE BRANCH

x

Reset

• fix/external-da-pointer-events-block-clicks
• chore/coverage-adapter
• chore/coverage-amp
• chore/coverage-app-release-classifier
• chore/coverage-dashboard-go
• chore/coverage-database
• chore/coverage-donations-helpers
• chore/coverage-emailtracking
• chore/coverage-embedding
• chore/coverage-export
• chore/coverage-handler
• chore/coverage-image
• chore/coverage-isochrone
• chore/coverage-merge
• chore/coverage-misc
• chore/coverage-namegen
• chore/coverage-reusebenefit
• chore/coverage-sentrylog
• chore/coverage-sso
• chore/coverage-team
• chore/coverage-use-blur-detector
• chore/coverage-use-distance
• chore/coverage-use-suppress-exception
• chore/coverage-use-typewriter
• chore/coverage-useTimeFormat
• chore/coverage-useTwem
• chore/coverage-utils
• chore/coverage-utils-flex-json
• chore/coverage-vectorsearch-20260422
• chore/coverage-worrywords-edge-cases
• chore/pr-template
• chore/skip-iznik-server-ci-tests
• cleanup/retire-cake-for-mods
• coverage/Go-tdd
• coverage/event-filtering-tests
• coverage/go-1714999056
• coverage/go-status-readgithead-2026-04-29
• coverage/go-tryst-20260503
• coverage/laravel-gemini-service-20260504
• coverage/laravel-message-commands-2026-05-02
• coverage/useModMessages-uncovered-branches-1777447042
• coverage/vitest-uppy-retry-coalescer-2026-05-07
• coverage/vitest-use-trace-20260425
• diagnose/repost-group-change-dom-dump
• feat/archive-attachments
• feat/batch-migrate-non-email-jobs
• feat/batch-migrate-remaining-scripts
• feat/birthday-emails
• feat/chat-chaseup-mods
• feat/chat-review-notify
• feat/chat-review-pending
• feat/contentcheck-pipeline
• feat/digest-reply-notice
• feat/donations-daily-summary
• feat/engage-emails
• feat/events-digest
• feat/group-customisation
• feat/groups-closed-reminder
• feat/groups-no-messages
• feat/lovejunk-tn-invoice
• feat/microvolunteering-notify
• feat/mod-active-welfare
• feat/modtools-capacitor-app
• feat/newsfeed-mod-notif
• feat/noticeboard-thank-email
• feat/stories-ask
• feat/stories-to-central
• feat/tn-names-fix
• feat/tryst-calendar-reminders
• feat/volunteering-digest
• feat/welcome-review
• feature/ai-image-prompt-improvements
• feature/ai-image-regen
• feature/android-coldstart-safe
• feature/batch-deadlock-fixes
• feature/batch-deadlock-fixes-v2
• feature/batch-jobs-dry-run-and-fixes
• feature/bounce-users-suspension
• feature/cansubmit-messagevalid
• feature/charity-badge
• feature/chat-api-test-coverage
• feature/chat-button-modifier-keys
• feature/chat-expected-migration
• feature/chat-process-migration
• feature/chat-spam-migration
• feature/check-spammers-migration
• feature/cloudflare-ai-images
• feature/cls-improvements
• feature/concern-keywords
• feature/coverage-20260429
• feature/coverage-laravel-event-listeners
• feature/coverage-message
• feature/coverage-postcode-remapping
• feature/coverage-vitest-1777133352
• feature/coverage-vitest-20260504
• feature/eee-identification
• feature/enable-batch-jobs
• feature/engage-update-migration
• feature/exports-migration
• feature/frontend-design-refresh
• feature/giftaid-chaseup-migration
• feature/go-coverage-group
• feature/go-coverage-pr
• feature/hybrid-embedding-search
• feature/memberships-process-migration
• feature/message-search-index-migration
• feature/migrate-http-endpoints
• feature/mobile-feel
• feature/mod-notifs-migration
• feature/modtools-mod-mail-logging-9518
• feature/monitor-fsm-process-quality
• feature/monitor-fsm-sqlite
• feature/multi-group-messages
• feature/notification-chaseup-email
• feature/putmessage-item-validation
• feature/reply-to-chat
• feature/retire-subject-line-settings
• feature/search-filter-tests
• feature/search-relevance-fix-9585
• feature/session-settings-defaults
• feature/social-login-profile-pictures
• feature/tdd-coverage-changes-endpoint
• feature/test-go-location-isochrones
• feature/unified-digest-revision
• feature/users-modmails-migration
• feature/vector-search
• feature/vite8-build-speed
• feature/wire-concern-keywords
• fix-295
• fix/add-member-409
• fix/ai-image-test
• fix/ai-images-9646-1
• fix/approved-members-infinite-scroll
• fix/authority-autocomplete-crash
• fix/auto-repost-excessive-9481
• fix/auto-repost-missing-items-9481
• fix/banned-members-pagination-test
• fix/chat-notifications-closed-blocked
• fix/chat-phone-warning-false-positive-9518
• fix/chat-review-message-merge
• fix/chitchat-ios-cardinality
• fix/chitchat-ios-limited-posts
• fix/chitchat-scroll-history
• fix/duplicate-link-collection
• fix/eee-browser-submitting-flag
• fix/exclude-location-triggers-postcode-remap
• fix/gradle-plugin-portal
• fix/group-contact-label-9643-1
• fix/index-vue-onserverprefetch-deterministic-coverage
• fix/jobimg-9630-6
• fix/member-deletion-status
• fix/member-review-ignore-noop-9618
• fix/merge-api-return-logins-v1-parity
• fix/message-log-historical-name
• fix/message-log-historical-subject
• fix/message-summary-eager-image-loading
• fix/missing-received-logs
• fix/mod-admin-send-pending-400
• fix/modconfig-404-v1-parity
• fix/modlog-historical-blank-and-auto-approved-label
• fix/modlogs-dedup
• fix/modmail-log-pending-subject-9518-211
• fix/modmail-log-test-9518
• fix/modtools-banned-pagination-9518-246
• fix/modtools-chat-badge-stuck
• fix/modtools-chat-review-hover-reveal
• fix/modtools-chat-review-member-details
• fix/modtools-chat-review-member-details-9518-219
• fix/modtools-deleted-message-log-9622
• fix/modtools-email-branding
• fix/modtools-feedback-scroll
• fix/modtools-infinite-scroll-pagination
• fix/modtools-ios-add-note-chat-review-9518-234
• fix/modtools-login-port-assertion
• fix/modtools-member-review-buttons
• fix/modtools-members-9518-238
• fix/modtools-members-9518-238-modmail-filter-test
• fix/modtools-members-9518-238-work
• fix/modtools-members-9518-239
• fix/modtools-postcode-edit-iphone-ui
• fix/modtools-related-members-9631-16
• fix/modtools-related-members-9631-19
• fix/modtools-related-members-flash-and-filter
• fix/modtools-stdmsg-9644-1
• fix/monitor-bugs-batch
• fix/national-volunteers-v2-parity
• fix/out-of-area-postcode-test
• fix/patch-message-groupid-draft
• fix/pending-message-visibility
• fix/photos-vanished-9629
• fix/playwright-coverage-sourcefilter-exclusions
• fix/queue-fatal-error-sentry
• fix/rejected-message-item-when-no-locationid
• fix/related-members-9631-16
• fix/related-members-9642-1
• fix/related-members-counter-9631
• fix/related-members-counter-stuck-9631
• fix/related-members-deleted-filter
• fix/related-members-group-filter
• fix/reopen-closed-chat-on-message
• fix/review-ignore-held-members
• fix/search-white-goods-relevance-9585-18
• fix/sentry-7384446789-merge-logins-forEach
• fix/sentry-7421179445-mymessage-repost-null
• fix/sentry-failed-to-fetch-image-freegletusd
• fix/sentry-ftutils-getinnerdimensions-null
• fix/sentry-ftutils-getplacementposition-nuxt3-ces
• fix/sentry-ignore-freestar-ftutils-null
• fix/sentry-ignore-notreadable-io
• fix/sentry-in-operator-error-undefined
• fix/sentry-leaflet-tooltip-nullmap-nuxt3-d7b
• fix/sentry-nuxt3-d45-filter-undefined-error
• fix/session-series-bigint
• fix/spammer-patch-preserve-reporter
• fix/spammer-v1-parity-unconfirmed
• fix/stats-chart-types-and-ad-cssbind
• fix/stdmsg-delete-and-config
• fix/stdmsg-delete-config-9518
• fix/support-purge-queues-forget-task
• fix/test-failures-investigation
• fix/uppy-debounce-retry-all
• fix/v2-api-user-emails-message-postings
• fix/v2-patch-user-trustlevel-not-persisted
• fix/vector-keyword-whole-word
• fix/vector-search-keyword-boost
• fix/vector-search-subject-tier
• fix/vectorsearch-non-determinism-and-irrelevance
• fix/vectorsearch-threshold-white-goods
• fix/withdrawn-pending-soft-delete-403
• master
• monorepo/partnerships-page
• perf/modtools-messages-union-all
• pr-234
• pr-289
• production
• temp-rebase
• test-modspammer-crash-bug
• test/ai-image-regen-history
• test/auth-google-autoselect-coverage
• test/coverage-changes-handler
• test/coverage-chat-notifications
• test/coverage-go-auth-hashpassword
• test/coverage-go-group-create
• test/coverage-go-utils
• test/coverage-location-isochrone
• test/coverage-vitest-uppy-retry-coalescer-1777621557
• test/go-coverage-namevalidation-helpers
• test/group-mod-dismiss-403
• test/katapult-runner-e2e
• test/laravel-coverage-mail-helper
• test/message-package-coverage
• test/message-pure-coverage
• test/related-members-count-stale
• test/session-flexint-coverage
• tn-integration-refactor
• tn-sync-port-testing
• tn-sync-port-testing-local

Build # 5219

Build Type

Pull #222

circleci

Committed by edwh

Commit Message

fix(ads): allow clicks on Jobs and static ads once ad renders

Commit ba725baeb switched ExternalDa.vue's `passClicks` from a boolean
(silently-invalid CSS that always fell back to `auto`) to concrete
`'none'`/`'auto'` values but kept the same ternary direction, which
inverted the effective behaviour: once an ad/fallback resolved
(`adShown=true`), the container got `pointer-events: none` and blocked
clicks on Jobs links and static banner ads (Utility Warehouse, Temu,
etc.). Video ads were unaffected because they float above the container.

Flip the mapping so the rendered ad or fallback slot is clickable and
the empty placeholder is click-transparent, and update the existing
tests to codify the corrected contract.

Reported on Discourse #9481 posts 492/493.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Pull Request Pull Request #222: fix(ads): allow clicks on Jobs and static ads once ad renders

Coverage Stats

13444 of 20537 branches covered (65.46%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

95953 of 132291 relevant lines covered (72.53%)

22.17 hits per line