Freegle / Iznik
71%
master: 72%

LAST BUILD BRANCH: fix/moderation-rippling-9890-1
DEFAULT BRANCH: master
Repo Added
Files 1404
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH feat/admin-previous-fix
branch: feat/admin-previous-fix
CHANGE BRANCH
x

coverage: 71.157% (-0.009%) from 71.166%
22940

Pull #851

circleci

edwh 
fix(admin): restore sent-admin archive in Previous tab + stop cross-group leak

ModTools "Previous" admin tab showed only stale, approved-but-never-sent
admins (mods saw a years-old Christmas message as the newest), and Admin/
Support users saw pending admins for groups they aren't on.

Root cause: the V2 Go ListAdmins query filtered `complete IS NULL`, which
excludes every *sent* admin (those have `complete` set) - the opposite of
what the Previous archive needs. And the Admin/Support branch applied no
group scoping at all, so with no group selected it swept every group's
admins into the Pending tab.

Fix:
- Drop the `complete IS NULL` filter so sent admins appear again, matching
  V1 Admin::listForGroup (all admins for the group, newest first).
- Scope the default listing to the caller's active mod groups for everyone
  (matching V1 Admin::listPending); Admin/Support may still view a specific
  group's history when they explicitly request a groupid.

Tests: TestListAdminsIncludesCompleted (completed admins are returned);
TestListAdminsSystemAdmin reworked to assert no cross-group leak with no
group, and access to a specific requested group.

## Discourse

https://discourse.ilovefreegle.org/t/admin-messages/9816/4

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pull Request #851: fix(admin): restore sent-admin archive in Previous tab + stop cross-group leak

11141 of 14808 branches covered (75.24%)

Branch coverage included in aggregate %.

25 of 25 new or added lines in 1 file covered. (100.0%)

125 existing lines in 7 files now uncovered.

121881 of 172134 relevant lines covered (70.81%)

37.38 hits per line

Relevant lines Covered
172134 RELEVANT LINES 121881 COVERED LINES
37.38 HITS PER LINE
Source Files on feat/admin-previous-fix

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
22940 feat/admin-previous-fix fix(admin): restore sent-admin archive in Previous tab + stop cross-group leak ModTools "Previous" admin tab showed only stale, approved-but-never-sent admins (mods saw a years-old Christmas message as the newest), and Admin/ Support users saw pe... Pull #851 edwh circleci
71.16
See All Builds (1830)