FROSADO / onecloudriver

82%

main: 81%

LAST BUILD ON BRANCH issue-142-upload-path-parent-syntax

branch: issue-142-upload-path-parent-syntax

CHANGE BRANCH

x

Reset

• issue-142-upload-path-parent-syntax
• docs-contributing-pr-template
• feat(service)--Add-a-restart-command-to-service-command
• input/output-optimization-in-go-1190b
• issue-10-reuse-graph-client
• issue-101-root-level-delta
• issue-11-account-remove-confirmation
• issue-116-extract-shared-helpers
• issue-117-propagate-swallowed-errors
• issue-118-improve-coverage-least-covered-modules
• issue-120-oauth-state-pkce
• issue-124-remove-dead-deltalink-trim
• issue-129-rmdir-stale-childcount
• issue-131-update-indirect-deps
• issue-132-upgrade-go-toolchain
• issue-133-add-fuse-panic-handler
• issue-134-max-inflight-request-bytes
• issue-14-upload-retries-survive-outage
• issue-146-sync-detect-active-mount
• issue-147-control-socket-info
• issue-15-delta-preserve-local-changes
• issue-152-size-eviction-idle-grace
• issue-16-if-match-upload
• issue-17-align-offline-docs
• issue-20-fix-rpm-license
• issue-22-remove-account-cache-path
• issue-26-emoji-rule-contributing
• issue-28-shell-ascii-fallback
• issue-29-symbol-table
• issue-3-extract-account-helper
• issue-30-i18n-plan
• issue-32-quickxorhash
• issue-33-multipart-download-regression
• issue-35-consolidate-uninstall
• issue-36-agents-md
• issue-39-list-target-folder
• issue-4-build-resource-helper
• issue-40-fix-systemd-tilde-mountpoint
• issue-41-service-list
• issue-41-service-list-fix
• issue-42-service-status
• issue-43-service-output
• issue-44-fix-packaging-unit-percent-escaping
• issue-45-fix-execstart-binary-resolution
• issue-47-doc-service-man-page
• issue-48-consolidate-cmd-boilerplate
• issue-49-keyring-key-helpers
• issue-5-dependency-injection
• issue-50-consolidate-eviction
• issue-53-fix-rpm-cpio-pattern
• issue-6-split-service
• issue-64-atomic-upload-snapshot
• issue-65-content-cache-heap
• issue-67-serialize-dirty
• issue-68-streaming-delta-apply
• issue-69-zero-copy-upload
• issue-7-emoji-fallback
• issue-70-tune-http-transport
• issue-71-prewarm-depth
• issue-72-bench-baseline
• issue-73-manual-sync
• issue-74-observability
• issue-75-harden-boltdb-timeout
• issue-78-coverage-integration
• issue-8-add-yaml-output-support
• issue-81-release-v0.1.3
• issue-83-rename-local-file
• issue-85-session-only-cache-dir
• issue-87-fix-empty-flush-upload
• issue-9-standardize-flag-validation
• issue-coverage-improvement
• main
• no-issue-update-make-doc
• perf/issue-66-inode-cache-swepp
• release-prep-v0.1.4
• release-v0.1.5
• release-v0.1.6
• report-coverage

Build # 33958021911

Build Type

Pull #145

github

Committed by FROSADO

Commit Message

fix(graph): build upload child path for ItemPath parents without double :/ (Closes #142)

UploadItem and UploadItemStream built the target URL by concatenating
parent.ResourcePath() with ":/" + fileName. For an ItemPath parent,
ResourcePath() already contains the ":/" path separator, so the result
was /me/drive/root:/Documents:/file, which Graph rejects with HTTP 400
"Resource not found for the segment 'root:'".

Extract uploadItemResourcePath to build the child address per parent kind:
ItemID parents keep the legacy /me/drive/items/<id>:/<file> form, while
ItemPath parents append the file name as a plain path segment
(/me/drive/root:/<folder>/<file>). Add regression and table-driven tests.

Pull Request Pull Request #145: fix(graph): upload --path fails with 400 Resource not found for the segment 'root:'

Coverage Stats

16 of 16 new or added lines in 1 file covered. (100.0%)

6231 of 7640 relevant lines covered (81.56%)

3260.12 hits per line