FROSADO / onecloudriver

77%

main: 78%

LAST BUILD ON BRANCH issue-85-session-only-cache-dir

branch: issue-85-session-only-cache-dir

CHANGE BRANCH

x

Reset

• issue-85-session-only-cache-dir
• docs-contributing-pr-template
• issue-10-reuse-graph-client
• issue-101-root-level-delta
• issue-14-upload-retries-survive-outage
• issue-15-delta-preserve-local-changes
• issue-16-if-match-upload
• issue-17-align-offline-docs
• issue-20-fix-rpm-license
• issue-22-remove-account-cache-path
• issue-26-emoji-rule-contributing
• issue-28-shell-ascii-fallback
• issue-29-symbol-table
• issue-3-extract-account-helper
• issue-32-quickxorhash
• issue-33-multipart-download-regression
• issue-35-consolidate-uninstall
• issue-36-agents-md
• issue-4-build-resource-helper
• issue-40-fix-systemd-tilde-mountpoint
• issue-44-fix-packaging-unit-percent-escaping
• issue-45-fix-execstart-binary-resolution
• issue-47-doc-service-man-page
• issue-49-keyring-key-helpers
• issue-50-consolidate-eviction
• issue-53-fix-rpm-cpio-pattern
• issue-6-split-service
• issue-64-atomic-upload-snapshot
• issue-67-serialize-dirty
• issue-68-streaming-delta-apply
• issue-69-zero-copy-upload
• issue-7-emoji-fallback
• issue-70-tune-http-transport
• issue-72-bench-baseline
• issue-73-manual-sync
• issue-75-harden-boltdb-timeout
• issue-78-coverage-integration
• issue-8-add-yaml-output-support
• issue-81-release-v0.1.3
• issue-83-rename-local-file
• issue-87-fix-empty-flush-upload
• issue-9-standardize-flag-validation
• main
• no-issue-update-make-doc
• report-coverage

Build # 31941645570

Build Type

Pull #86

github

Committed by FROSADO

Commit Message

fix(mount): make --cache-dir a session-only override (#85)

A one-off `mount --cache-dir /tmp/...` permanently overwrote the
account JSON (`acc.Mount.CacheDir`), so future mounts (e.g. systemd
service restarts) pointed at a temporary path — which, once deleted,
crash-looped the services until the config was manually restored.

- mount.go: track whether --cache-dir came from the flag and exclude
  it from the persisted config (new buildPersistedMountConfig helper);
  print "(session only, not saved to account config)" when used.
- All other flag overrides (cache-ttl, delta-interval, ...) are safe
  scalars and keep being persisted as before.
- Tests: buildPersistedMountConfig keeps the previous CacheDir when
  the flag is given (also when the persisted value is empty) and
  persists all other fields; persists CacheDir when no flag is set.
- Docs: flag help, command Long text, MANUAL.md/.es, ARCHITECTURE*
  now document the session-only semantics.

Generated with Codebuff 🤖
Co-Authored-By: Codebuff <noreply@codebuff.com>

Pull Request Pull Request #86: fix(mount): make --cache-dir a session-only override (#85)

Coverage Stats

15 of 27 new or added lines in 1 file covered. (55.56%)

2 existing lines in 1 file now uncovered.

3848 of 4976 relevant lines covered (77.33%)

479.69 hits per line