FEniCS / ufl
80%

DEFAULT BRANCH: main
Repo Added
Files 109
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 79.746% (+0.2%) from 79.553%
32257537194

push

github

web-flow 
Cancel contractions of the Jacobian with its inverse (#496)

* Cancel contractions of the Jacobian with its inverse

Preserve Jacobian, JacobianInverse and JacobianDeterminant during
geometry lowering, and cancel J-Jinv contractions into Kronecker
deltas before the inverse is expanded into individual matrix entries.
Eliminate the resulting Identity tensors by contraction against the
remaining factors, and cancel reciprocal factors within products,
such as detJ**2 * (1/detJ)**2.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Address review: convert to DAGTraverser, add tests

IndexSumSimplifier (and its JacobianCanceller/IdentityEliminator
subclasses) and ReciprocalCanceller were plain MultiFunctions; convert
them to DAGTraverser, matching the convention used by the rest of the
newer algorithms modules (apply_derivatives.py,
apply_coefficient_split.py). This switches the driver function from
map_integrand_dags (the MultiFunction-compatible entry point) to
map_integrands, since a DAGTraverser is called directly rather than
through map_expr_dag.

Add test/test_cancel_jacobian_products.py, covering JacobianCanceller
and IdentityEliminator on both contraction orders (J.K and K.J),
ReciprocalCanceller on both a fully- and a partially-cancelling
reciprocal product, the full pass end-to-end on a div-div form over a
contravariant Piola-mapped (Raviart-Thomas) element (verifying both
the size reduction and that the opt-in flag defaults to off), and a
no-op check on a form with no Jacobian contractions to cancel.

* Address review: test mathematical correctness, not just size/absence

The div-div test only checked that the cancelled integrand's string
representation was shorter than the uncancelled one -- a check that
would pass even for a wrong simplification, as long as it happened to
produce something smaller.

Replace it with two meaningful checks against the intermediate result
cancel_jacobian_products actually produces (before further geometry
... (continued)

201 of 229 new or added lines in 2 files covered. (87.77%)

9989 of 12526 relevant lines covered (79.75%)

0.8 hits per line

Relevant lines Covered
12526 RELEVANT LINES 9989 COVERED LINES
0.8 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32257537194 main Cancel contractions of the Jacobian with its inverse (#496) * Cancel contractions of the Jacobian with its inverse Preserve Jacobian, JacobianInverse and JacobianDeterminant during geometry lowering, and cancel J-Jinv contractions into Kronecker... push web-flow github
79.75
32009042654 main Fix generic terminal traversal for BaseForm types in extract_domains (#502) * Fix extract_domains for BaseForm to expand MeshSequence The BaseForm-not-Expr branch added in #494 returned expr.ufl_domains() directly, skipping the join_domains/sort... push web-flow github
79.55
31370183750 main Fix generic terminal traversal for BaseForm types in extract_domains (#502) * Fix extract_domains for BaseForm to expand MeshSequence The BaseForm-not-Expr branch added in #494 returned expr.ufl_domains() directly, skipping the join_domains/sort... push web-flow github
79.55
31081250646 main Fix generic terminal traversal for BaseForm types in extract_domains (#502) * Fix extract_domains for BaseForm to expand MeshSequence The BaseForm-not-Expr branch added in #494 returned expr.ufl_domains() directly, skipping the join_domains/sort... push web-flow github
79.55
30999691016 main Fix ZeroBaseForm holes in derivative expansion and action (#494) * Fix ZeroBaseForm holes in derivative expansion and action GateauxDerivativeRuleset had no rule for ZeroBaseForm itself, so differentiating an already-zero BaseForm (e.g. a Hessia... push web-flow github
79.58
30799575092 main Formatting fixes with latest ruff (#499) push web-flow github
79.46
30254296886 main Formatting fixes with latest ruff (#499) push web-flow github
79.46
29894207343 main Bump actions/setup-python from 6 to 7 (#498) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6 to 7. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](https://github.com/actions/setup-pytho... push web-flow github
79.46
29729689525 main Simplify trivial FormSum (#492) push web-flow github
79.46
29078259611 main Simplify trivial FormSum (#492) push web-flow github
79.46
See All Builds (236)