ExpediaGroup / bull
100%
master: 100%

LAST BUILD BRANCH: develop
DEFAULT BRANCH: master
Repo Added
Files 60
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH develop
branch: SELECT
CHANGE BRANCH
x

coverage: 100.0%. Remained the same
#1407

push

web-flow 
Fix/collection element field transformer null regression (#654)

* fix: prevent NPE when field transformer is applied to collection elements with flat field name mapping

When a CollectionPopulator transforms list elements (e.g. List<PersonSvc> -> List<Person>),
it calls transformer.transform(elem, targetClass) without a breadcrumb. In resolveEffectiveSource,
evalBreadcrumb("fieldName", null) returns just "fieldName", which could match a simple flat
field mapping (e.g. "name" -> "fullName"). This caused the lookup to incorrectly redirect to
the root source object instead of the current element, and getSourceFieldValue silently returned
null (swallowing the MissingFieldException because a transformer was defined), ultimately
passing null into the user's transformer function and triggering a NullPointerException.

Fix: guard the breadcrumb-based mapping lookup with isNotEmpty(breadcrumb) so root-source
redirection only occurs when there is an actual breadcrumb prefix in the path.

* test: add regression tests for collection element field transformer NPE

Add tests verifying that field transformers using flat field name transformation
correctly use the collection element as the source, not the root object.

New sample classes:
- FromFooWithFullName: source item with a fullName field
- FromFooContainingList: root source with id + List<FromFooWithFullName>
- ImmutableToFooWithSplitName: target item with name + surname fields
- ImmutableToFooContainingList: root target with id + List<ImmutableToFooWithSplitName>

New tests in MixedObjectTransformationTest:
- testFieldTransformerOnCollectionElementsUsesElementNotRootAsSource: verifies
  that withFieldMapping + withFieldTransformer on collection elements reads from
  the element, not the root (would have NPEd before the fix)
- testAllCollectionElementsAreIndependentlyTransformedFromTheirOwnSource: verifies
  each element is transformed from its own source independently

Also adds resetFieldsMapping() to Abstr... (continued)

4 of 4 new or added lines in 1 file covered. (100.0%)

1225 of 1225 relevant lines covered (100.0%)

1.95 hits per line

Relevant lines Covered
1225 RELEVANT LINES 1225 COVERED LINES
1.95 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
#1407 develop Fix/collection element field transformer null regression (#654) * fix: prevent NPE when field transformer is applied to collection elements with flat field name mapping When a CollectionPopulator transforms list elements (e.g. List<PersonSvc> ->... push web-flow
100.0
#1406 master Fix/collection element field transformer null regression (#654) * fix: prevent NPE when field transformer is applied to collection elements with flat field name mapping When a CollectionPopulator transforms list elements (e.g. List<PersonSvc> ->... push web-flow
100.0
#1405 fix/collection-element-field-transformer-null-regression [maven-release-plugin] prepare for next development iteration Pull #654 fborriello
100.0
#1404 7c93dc54f771ac2c3a8e29eb7e518aae7cdd2b84 Merge 6e86e9db9 into dcae9cff8 push web-flow
100.0
#1403 fix/collection-element-field-transformer-null-regression [maven-release-plugin] prepare release 3.0.2 push fborriello
100.0
#1402 a2e6c6efd65bf602eb06c9388a27292008bf7307 Merge 62e7056ca into dcae9cff8 push web-flow
100.0
#1401 3a4d2e83202d1bb630171ed6667bff1bf98038b9 Merge d07a1c54b into dcae9cff8 push web-flow
100.0
#1400 fix/collection-element-field-transformer-null-regression test: add regression tests for collection element field transformer NPE Add tests verifying that field transformers using flat field name transformation correctly use the collection element as the source, not the root object. New sample classes:... push fborriello
100.0
#1399 fix/collection-element-field-transformer-null-regression fix: prevent NPE when field transformer is applied to collection elements with flat field name mapping When a CollectionPopulator transforms list elements (e.g. List<PersonSvc> -> List<Person>), it calls transformer.transform(elem, targetClass) w... push fborriello
100.0
#1398 master Bump org.sonatype.central:central-publishing-maven-plugin (#647) Bumps [org.sonatype.central:central-publishing-maven-plugin](https://github.com/sonatype/central-publishing-maven-plugin) from 0.7.0 to 0.10.0. - [Commits](https://github.com/sonaty... push web-flow
100.0
See All Builds (1408)