ExpediaDotCom / haystack-pipes

100%

master: 100%

LAST BUILD ON BRANCH AddBackSynchronized

branch: AddBackSynchronized

CHANGE BRANCH

x

Reset

• AddBackSynchronized
• AddCoverallsBadge
• AddDockerFilesToHttpPoster
• AddFilteringToHttpPoster
• AddGraphiteConfigs
• AddLogbackDotXmlFileToFixBuild
• AddMaxBytesConfiguration
• AddShutdownHookToClearBatchOnJvmStop
• AddTestBaseDotYamlFileToFixBuild
• AddThreadCountConfig
• BackToFullCoverage
• BeginningsOfSpringConfiguration
• BetterLoggingOnFailures
• BumpHaystackMetricsAndCustomAppendersVersions
• ChangeBatchLogFromWarnToError
• ChangeCopyrightTo2018
• ChangeLogLevelForBatchClass
• ChangePollingIntervalTo5Minutes
• CollapseConfigurationsAndCallSetOutput
• CollapseLimitChecksIntoSingleMethod
• CountExceptions
• CountThrottles
• EternalRetryForFirehose
• FinishFirehoseWriter
• FinishHttpPosterImplementationAndTests
• FinishSpringConfig
• FirehoseBeginnings
• FixDateTimeInLogLine
• FixFilenameInPomDotXml
• FixMainClass
• FixMainClassInPomXml
• FixNpeInTagFlattener
• FleshOutContentCollector
• FullSpringification
• IncreaseHttpPostSizePerNewDopplerBehavior
• IncreaseMemoryForHttpPoster
• InitializeRecordsListToSize500
• LRemoveUnusedSpringBean
• LogAtActionStarup
• LogFirstExceptionInErrorLogEntry
• LogKafkaTopicsAtStartup
• LowerSleepStep
• MakeIntegerConfigurationsStrings
• MakeMainClassPublic
• MoreConfigsForPost
• MoreDocumentation
• MoreFlexibleCountersAndTimer
• MoreUnitTestsForSpringConfig
• MoreWorkOnFirehoseWriter
• MoveTagFlatteningToCommons
• NewHaystackMetricsAndAppenders
• PortAlreadyInBrokerList
• PublishFireshoseWriterToDocker
• ReleaseHttpPosterToDocker
• RemoveExpediaUrlFromHttpPosterConfigs
• RemoveGClinesFromJmxTransDotXml
• RemoveNewLinesFromStackTraces
• SpringConfigUnitTests
• SpringifyJsonTransformer
• SpringifyKafkaProducer
• UpdateHaystackMetricsTo080
• UpdateReadMe
• UpgradeKafka
• UpgradeSpringMavenPluginsVersion
• UseDifferentSubsystems
• UseKstreamsProducer
• UseLog4j2InFirehoseWriter
• UseSharedRandomInTests
• batch-timer
• health-check-implementation
• improve-batch-handling
• master
• useNonResettingCounterForPostsInFlight

Build # 411

Build Type

push

travis-ci

Committed by jeffbakerexpedia

Commit Message

Put back the synchronized keyword on the method addRecordAndReturnBatch(),
because the change resulted in an ArrayIndexOutOfBoundsException. I suspect
some subtle bug in the Java memory model is responsible for this breakage.
Also made returnIncompleteBatch() synchronized as well; this method only
runs on shutdown but it seemed more consistent to have both methods
synchronized.

Run Details

766 of 766 relevant lines covered (100.0%)

1.0 hits per line