DemocracyClub / yournextrepresentative

68%

master: 68%

LAST BUILD ON BRANCH hotfix/round-percentages

branch: hotfix/round-percentages

CHANGE BRANCH

x

Reset

• hotfix/round-percentages
• 2022-leaderboard
• 2022-sopn-tracker
• 2023-leaderboard
• 2024-ge-sopn-dashboard
• add-missing-migrations
• add-previous-party-affiliation-to-api
• api-voting-system-filter
• ballot-based-recently-updated
• ballot-endpoint
• better-user-signup
• bugfix/ballot-lock
• bugfix/ec-id-length
• bugfix/front-page-links
• bugfix/import-emblems
• bugfix/pdf-convert
• bugfix/previous-party-affiliations
• bugfix/results-2022
• bugfix/sopn-parsing
• bugfix/sopn-stats
• candidate-bot-twitter-usernames
• candidatebot-learns-twfy
• catch-bad-postcodes
• catch-base-pdf-exception
• clean-person-names
• completeness-per-election
• completeness-performance
• convert-image-from-url-to-png
• count-current-elections-after-check-current
• csv-filter-on-nuts1
• csv-import-party-desc
• csv-maker-updates
• csv_sopns
• data_exporter
• default-to-textract
• default-winner-count
• delete-google
• delete-parsed-people
• dependabot-march
• dependabot/pip/moto-s3--5.0.23
• dependabot/pip/moto-s3--5.0.26
• deploy-after-tests
• dos-20241113
• election-dashboards
• election-tts423
• email-notifiations-on-sopn-change
• example-parl-elections
• exclude-parties-from-name-search
• expose-tags-in-api
• feat/update-party-importer
• feature/1373-remove-copyright-middleware
• feature/2024-candidate-ordering
• feature/add-party-nations
• feature/add-turnout-and-spoilt-ballots
• feature/better-number-inputs
• feature/bot-can-import-results
• feature/candidatebot_import_from_csv_export
• feature/delete-results
• feature/easier-for-reviewers
• feature/improve-recent-changes-list
• feature/list-position
• feature/locked-name-edits
• feature/parse-textract-results
• feature/person-name-changes
• feature/person-redirect-last-updated-filter
• feature/photo-uploader-updates
• feature/photo-uploader-updates-new
• feature/playwright-frontend-testing
• feature/previous-political-affiliation
• feature/redesign-sopn-models
• feature/remove-dead-person-links
• feature/validate-death-date
• feature/view-parsed-sopn-data
• feature/wikidata-mnis-ids
• fix-aws-sopn-images
• fix-clean-person-identifier-regexes
• fix-has-resultset-filter
• fix-party-pages
• fix-person-name-cleanup-typo
• fix-primary-image-data-migration
• fix-rgba-emblems
• fix-sopn-stats
• fix-sopn-upload
• fix-sopn-urls
• fix-sopn-viewer
• fix-spaces-in-file-names
• fix-test-datetime
• fix-womble-pages
• fix/sync-GSS-codes
• forms-for-previous-party
• front-page-links
• ge-leaderboard
• gender-winners
• hide-extra-bulk-adding-rows
• hide-results-link-for-non-fptp
• highlight-withdrawal-cell
• hotfix/allow-parliament-emails
• hotfix/anti-vandalism
• hotfix/biography-in-markdown
• hotfix/cronjob-deploy
• hotfix/date-format
• hotfix/deselected-source
• hotfix/disable-may-2024-leaderboard
• hotfix/django-vulnerability
• hotfix/dont-accept-blank-values
• hotfix/downsize-elements
• hotfix/ec-emblem-import
• hotfix/emblem-update
• hotfix/enable-2024-leaderboard
• hotfix/fix-ec-party-importer
• hotfix/fix-person-image-migration
• hotfix/fix-results-header
• hotfix/fix-sopn-dates
• hotfix/fix-surname-parsing
• hotfix/fix-updated-timestamp
• hotfix/image-key-error
• hotfix/import-next-ppcs
• hotfix/known-candidates
• hotfix/mansfield-indie-emblem
• hotfix/mark-elected-when-uncontested
• hotfix/mastodon-serializer
• hotfix/mod-queue-storage-backend
• hotfix/modgov-urls-2023
• hotfix/more-frequent-data-download
• hotfix/more-person-identifiers
• hotfix/more-results-columns
• hotfix/new-tab-for-image-search
• hotfix/new-user-count
• hotfix/next-person-versions-endpoint
• hotfix/notices-for-users
• hotfix/parl-results-progress
• hotfix/party-count
• hotfix/party-emblems
• hotfix/password-reset
• hotfix/person-image-timestamp
• hotfix/photo-key-error
• hotfix/photo-upload-exception
• hotfix/post-sopn-home-page
• hotfix/preserve-transparent-background
• hotfix/record-photo-upload
• hotfix/reduce-scrolling
• hotfix/remote-twitterbot
• hotfix/remove-sopn-tracker
• hotfix/remove-twitter-auth
• hotfix/replace-rotate-buttons
• hotfix/report-a-problem
• hotfix/reset-home-page
• hotfix/results-cta
• hotfix/results-form-audit
• hotfix/results-with-decimals
• hotfix/rotate-photo-form
• hotfix/rotate-photo-key-error
• hotfix/rotate-photos-mgmt-command
• hotfix/set-rank-with-migration
• hotfix/set_frontpage_sopn
• hotfix/slack-notifications
• hotfix/sopn-date-nation
• hotfix/special-character-search
• hotfix/src-files
• hotfix/strip-whitespace-for-name-search
• hotfix/typo
• hotfix/unsupported-lookup-officialdocument
• hotfix/upcase-ec-id
• hotfix/update-sopn-settings
• hotfix/update-sopn-source-url
• hotfix/validate-linkedin
• hotfix/validate-parliament-emails
• hotifx/prevent_duplicate_candidacies
• import-current-statuses
• jcm/add-local-dev-container-workflows
• jcm/hello-world
• jcm/move-gulp-outside-ynr-dir
• jcm/wip
• joint-parties
• labour-api-import
• last-updated-gte
• latest-membership-in-search
• link-to-data-exporter
• locked-filter-on-csv
• longer-auth-tokens
• m1_readme_update
• make-import-sopns
• master
• may-24-polls-close
• may-24-results
• merge-and-revert-previous-affiliations
• missing-migration-dependencies
• mnis-ids-in-csv
• modgov-results-2022
• mop-up-recent-elections
• name-fields-2022
• name-search-improvements
• page-duplicates
• parse-welsh-sopns
• party-description-on-sopn-review
• pause-new-account-creation
• pmk01-patch-11
• pmk01-patch-12
• pmk01-patch-13
• pmk01-patch-14
• pmk01-patch-15
• pmk01-patch-16
• pmk01-patch-17
• pmk01-patch-5
• pmk01-patch-6
• pmk01-patch-8
• post-sopn-refactor-fixes
• post-to-slack-again
• prevent-adding-single-candidte-when-sopn-uploaded
• prevent-photo-upload-of-locked-candidate
• re-enable-account-creation
• reason-in-sopn-replacement
• remove-black
• remove-bot-workaround
• remove-email-logger
• remove-old-csv-from-cron
• remove-page-not-found-log
• remove-pi-constraint
• remove-results-csv
• remove-submodules-from-instructions
• remove-uk-results-entering-code
• reparse-sopns
• reports/include-cancelled
• reports/nuts1
• reports/undercontested
• result-on-person-serializer
• rtfm
• settings-from-env
• sopn-day-changes
• sopn-sheet-for-countries
• sort-name-fix
• spike/aws-textract
• store-other-name-from-bulk-add
• stv-results-link
• subbranch_of_aws_textract
• textract-interface-improvements
• three-way-duplicate-fix
• uk-election-pkgs20241112
• uk-election-timetables-4.2.2
• uncontested-ballot-report
• update-existing-candidates-in-ppc-sheet
• update-party-count-results-tracker
• upgrade-black
• various-small-updates
• wards-contested-per-ward
• welsh-helpers

Build # 7b270f66-fb09-4c98-9907-5de6d62e36da

Build Type

Pull #2428

circleci

Committed by VirginiaDooley

Commit Message

Round before reformatting percentage input

This fixes a previous PR that sought to remove decimals
and round percentages to the nearest whole number.
The order of operations was causing 50.55 to become 5055.

This change fixes that bug and handles input such as
50,55
50.55%
50,55%
50%

Pull Request Pull Request #2428: Round percentage turnout to the nearest whole number

Run Details

1561 of 2832 branches covered (55.12%)

Branch coverage included in aggregate %.

7489 of 10496 relevant lines covered (71.35%)

0.71 hits per line