DemocracyClub / yournextrepresentative

68%

master: 67%

LAST BUILD ON BRANCH ballot-based-recently-updated

branch: ballot-based-recently-updated

CHANGE BRANCH

x

Reset

• ballot-based-recently-updated
• 2022-leaderboard
• 2022-sopn-tracker
• 2023-leaderboard
• 2024-ge-sopn-dashboard
• add-cloudfront
• add-missing-migrations
• add-previous-party-affiliation-to-api
• add-results-summary-to-ballot-page
• api-voting-system-filter
• auto-update-leaderboards
• ballot-endpoint
• basic-auth
• better-user-signup
• bleach-nh3
• block20250527
• bug/hurl_version
• bug/linting
• bug/shellcheck
• bug/task_selection
• bugfix/ballot-lock
• bugfix/ec-id-length
• bugfix/front-page-links
• bugfix/import-emblems
• bugfix/pdf-convert
• bugfix/previous-party-affiliations
• bugfix/results-2022
• bugfix/sopn-parsing
• bugfix/sopn-stats
• by-election-reason
• candidate-bot-twitter-usernames
• candidatebot-learns-twfy
• catch-bad-postcodes
• catch-base-pdf-exception
• charismatic-election-dates-util
• ci/hurl-tests
• ci/linting
• ci/prune_old_task_definitions
• ci/test
• ci20250721
• cifail20250611
• clean-person-names
• completeness-per-election
• completeness-performance
• convert-image-from-url-to-png
• count-current-elections-after-check-current
• csv-filter-on-nuts1
• csv-import-party-desc
• csv-interface-improvements
• csv-maker-updates
• csv_sopns
• data_exporter
• de-duplicate-winners
• default-to-textract
• default-winner-count
• delete-google
• delete-orphan-posts
• delete-parsed-people
• dependabot-march
• dependabot/pip/moto-s3--5.0.23
• dependabot/pip/moto-s3--5.0.26
• deploy-after-tests
• django-q-20250929
• docs/env_creation
• docs/running_cdk_tests
• dos-20241113
• ecs-settings20250825
• election-dashboards
• election-tts423
• email-config
• email-notifiations-on-sopn-change
• example-parl-elections
• exclude-parties-from-name-search
• expose-tags-in-api
• feat/more-fields-for-bulk-add-by-party-form
• feat/update-party-importer
• feat/update-resultevent-admin
• feature/1373-remove-copyright-middleware
• feature/2024-candidate-ordering
• feature/add-party-nations
• feature/add-turnout-and-spoilt-ballots
• feature/aws_exec
• feature/better-number-inputs
• feature/bot-can-import-results
• feature/branch_tests
• feature/candidatebot_import_from_csv_export
• feature/cdk_resource_tagging
• feature/ci-triggers
• feature/create_staging_env
• feature/delete-results
• feature/django-q2
• feature/easier-for-reviewers
• feature/environment_prevalidation
• feature/improve-recent-changes-list
• feature/list-position
• feature/locked-name-edits
• feature/parse-textract-results
• feature/person-name-changes
• feature/person-redirect-last-updated-filter
• feature/photo-uploader-updates
• feature/photo-uploader-updates-new
• feature/playwright-frontend-testing
• feature/previous-political-affiliation
• feature/redesign-sopn-models
• feature/remove-dead-person-links
• feature/validate-death-date
• feature/view-parsed-sopn-data
• feature/wikidata-mnis-ids
• fix-aws-sopn-images
• fix-clean-person-identifier-regexes
• fix-container-ci-build
• fix-duplicate-pis-error
• fix-has-resultset-filter
• fix-importer-missing-parent
• fix-migration20250722
• fix-migrations20250721
• fix-party-pages
• fix-person-name-cleanup-typo
• fix-primary-image-data-migration
• fix-results-bot-election-ids
• fix-results-filter
• fix-rgba-emblems
• fix-shell-scripts
• fix-sopn-parsing-test
• fix-sopn-stats
• fix-sopn-upload
• fix-sopn-urls
• fix-sopn-viewer
• fix-spaces-in-file-names
• fix-territory
• fix-test-datetime
• fix-womble-pages
• fix/birth_date_validation
• fix/duplicate-ids-bug
• fix/edit-results
• fix/linkedin-urls
• fix/logged-action-description
• fix/markdown-lists
• fix/remove-add-winner-button-from-cancelled-election
• fix/results-bot-total-electorate
• fix/set_party_lists_in_use
• fix/sopn-uploader-doubled-input-on-click
• fix/stop-email-logging
• fix/sync-GSS-codes
• fix/turnout-percentage-field-type
• fix_build_script
• forms-for-previous-party
• front-page-links
• ge-leaderboard
• gender-winners
• healthcheck20250825
• hide-extra-bulk-adding-rows
• hide-results-link-for-non-fptp
• highlight-withdrawal-cell
• hot-reloads20250827
• hotfix/allow-parliament-emails
• hotfix/anti-vandalism
• hotfix/biography-in-markdown
• hotfix/cronjob-deploy
• hotfix/date-format
• hotfix/deselected-source
• hotfix/disable-may-2024-leaderboard
• hotfix/django-vulnerability
• hotfix/dont-accept-blank-values
• hotfix/downsize-elements
• hotfix/ec-emblem-import
• hotfix/emblem-update
• hotfix/enable-2024-leaderboard
• hotfix/fix-ec-party-importer
• hotfix/fix-person-image-migration
• hotfix/fix-results-header
• hotfix/fix-sopn-dates
• hotfix/fix-surname-parsing
• hotfix/fix-updated-timestamp
• hotfix/image-key-error
• hotfix/import-next-ppcs
• hotfix/known-candidates
• hotfix/mansfield-indie-emblem
• hotfix/mark-elected-when-uncontested
• hotfix/mastodon-serializer
• hotfix/mod-queue-storage-backend
• hotfix/modgov-urls-2023
• hotfix/more-frequent-data-download
• hotfix/more-person-identifiers
• hotfix/more-results-columns
• hotfix/new-tab-for-image-search
• hotfix/new-user-count
• hotfix/next-person-versions-endpoint
• hotfix/notices-for-users
• hotfix/parl-results-progress
• hotfix/party-count
• hotfix/party-emblems
• hotfix/password-reset
• hotfix/person-image-timestamp
• hotfix/photo-key-error
• hotfix/photo-upload-exception
• hotfix/post-sopn-home-page
• hotfix/preserve-transparent-background
• hotfix/record-photo-upload
• hotfix/reduce-scrolling
• hotfix/remote-twitterbot
• hotfix/remove-sopn-tracker
• hotfix/remove-twitter-auth
• hotfix/replace-rotate-buttons
• hotfix/report-a-problem
• hotfix/reset-home-page
• hotfix/results-cta
• hotfix/results-form-audit
• hotfix/results-with-decimals
• hotfix/rotate-photo-form
• hotfix/rotate-photo-key-error
• hotfix/rotate-photos-mgmt-command
• hotfix/round-percentages
• hotfix/set-rank-with-migration
• hotfix/set_frontpage_sopn
• hotfix/slack-notifications
• hotfix/sopn-date-nation
• hotfix/special-character-search
• hotfix/src-files
• hotfix/strip-whitespace-for-name-search
• hotfix/typo
• hotfix/unsupported-lookup-officialdocument
• hotfix/upcase-ec-id
• hotfix/update-sopn-settings
• hotfix/update-sopn-source-url
• hotfix/validate-linkedin
• hotfix/validate-parliament-emails
• hotifx/prevent_duplicate_candidacies
• import-current-statuses
• import-historic-results-data
• jcm/add-local-dev-container-workflows
• jcm/hello-world
• jcm/move-gulp-outside-ynr-dir
• jcm/wip
• joint-parties
• labour-api-import
• last-updated-gte
• last-updated-in-csv
• latest-membership-in-search
• link-to-data-exporter
• locked-filter-on-csv
• login-CAPTCHA
• logs20250919
• longer-auth-tokens
• m1_readme_update
• make-import-sopns
• master
• matt/cdk
• matt/wip
• may-24-polls-close
• may-24-results
• may-25-sopn-day
• merge-and-revert-previous-affiliations
• migrations20250917
• missing-commit
• missing-migration-dependencies
• mnis-ids-in-csv
• modgov-results-2022
• modgov-urls
• mop-up-recent-elections
• more-cloudfront-config
• more-modgov-fields
• name-fields-2022
• name-search-improvements
• osa-text
• page-duplicates
• papercuts20250826
• parse-welsh-sopns
• party-description-on-sopn-review
• pause-new-account-creation
• pmk01-patch-11
• pmk01-patch-12
• pmk01-patch-13
• pmk01-patch-14
• pmk01-patch-15
• pmk01-patch-16
• pmk01-patch-17
• pmk01-patch-5
• pmk01-patch-6
• pmk01-patch-8
• policy20250925
• post-sopn-refactor-fixes
• post-to-slack-again
• prevent-adding-single-candidte-when-sopn-uploaded
• prevent-photo-upload-of-locked-candidate
• prodenv202508
• pytest20250826
• re-enable-account-creation
• reason-in-sopn-replacement
• remove-black
• remove-bot-workaround
• remove-celery
• remove-email-logger
• remove-hustings-cta
• remove-old-csv-from-cron
• remove-orphan-posts
• remove-page-not-found-log
• remove-pi-constraint
• remove-results-csv
• remove-submodules-from-instructions
• remove-twitter-names-for-gdpr
• remove-uk-results-entering-code
• reparse-sopns
• reports/include-cancelled
• reports/nuts1
• reports/undercontested
• restore-home-page
• result-on-person-serializer
• results-bot-extra-fields
• results-bot-import-by-election-id
• results-bot-skip-tied-votes
• results-cta-2025-locals
• results-matching-25
• results-validation20240430
• rtfm
• runserver20250825
• s320250901
• scheduler20250910
• settings-from-env
• shellcheck20250820
• skip-already-found-modgov-urls
• skip-infra-test
• sopn-day-changes
• sopn-sheet-for-countries
• sort-name-fix
• sovereignty-party-emblem
• spike/aws-textract
• stage-cert-arn
• staging
• staging20250922
• store-other-name-from-bulk-add
• stv-results-link
• subbranch_of_aws_textract
• textract-interface-improvements
• three-way-duplicate-fix
• typo_fix
• uk-election-pkgs20241112
• uk-election-timetables-4.2.2
• uncontested-ballot-report
• update-existing-candidates-in-ppc-sheet
• update-party-count-results-tracker
• upgrade-black
• use-db-cache
• users-since-last-election
• various-small-updates
• wards-contested-per-ward
• welsh-helpers

Build # 1d735eb7-647f-4fe0-94e4-985e31f92ab2

Build Type

Pull #2491

circleci

Committed by symroe

Commit Message

Check ballots when checking recently updated

Previously, we would always check election objects (e.g the parent of a
ballot) first and then import all ballots for those elections.

This works well when importing for an election date, but doesn't work
when importing recent ballots.

After this change, we just iterate over the response from EE and add
each ballot to the election tree.

I did a little refactor to DRY up the iteration over the results URL as
part of this.

Pull Request Pull Request #2491: Check ballots when checking recently updated

Run Details

1556 of 2825 branches covered (55.08%)

Branch coverage included in aggregate %.

33 of 36 new or added lines in 1 file covered. (91.67%)

1 existing line in 1 file now uncovered.

7446 of 10460 relevant lines covered (71.19%)

0.71 hits per line