DemoBytom / DemoEngine
29%
develop: 26%

Repo Added 08 Feb 2020 11:14AM UTC

Committed 25 Feb 2026 10:52PM UTC coverage: 29.406% (+0.09%) from 29.317%

coveralls.net

Committed by

Commit Message

Async refactor - `StaThreadRequest` and `AsyncServiceScopes`

A warning was reported due to incorrectly disposing types that only implement `IAsyncDisposable`:
```
Demo.Engine Warning: 0 : AUTOFAC: A synchronous Dispose has been attempted, but the tracked object of type 'Demo.Engine.Core.Services.MainLoopService' only implements IAsyncDisposable. This will result in an inefficient blocking dispose. Consider either implementing IDisposable on 'Demo.Engine.Core.Services.MainLoopService' or disposing of the scope/container with DisposeAsync.
```

The solution was to use an `AsyncServiceScope` retreived via `_scopeFactory.CreateAsyncScope()` instead `IServiceScope` from `_scopeFactory.CreateScope()`.
This led to a bigger refactor as scopes were also created within `RenderingSurface` which in turn then required a `IAsyncDisposable` implementation. Changes in `RenderingSurface` required changes in `StaThreadRequests` and so on. Turtles all the way down 🐢🐢🐢
Currently all async methods are properly awaited and don't deadlock. But some `.ConfigureAwaits` might need to be added. This will be evaluated later.

Fixes #511

Coverage Stats

644 of 2190 relevant lines covered (29.41%)

0.32 hits per line

2190 RELEVANT LINES 644 COVERED LINES

0.32 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
22419506041	feature/small_fixes	Async refactor - `StaThreadRequest` and `AsyncServiceScopes` A warning was reported due to incorrectly disposing types that only implement `IAsyncDisposable`: ``` Demo.Engine Warning: 0 : AUTOFAC: A synchronous Dispose has been attempted, but the...	Pull #512	27 Feb 2026 07:48PM UTC	DemoBytom	coveralls.net	29.41
22265633171	feature/small_fixes	More logging fixes Migrated previously missed log invocations to source generated logging. Fixed some logging parameters not being PascalCase. Added 2 more diagnostics: - [CA2254: Template should be a static expression](https://learn.microsoft.co...	Pull #508	21 Feb 2026 10:37PM UTC	DemoBytom	coveralls.net	29.32
22265462213	feature/small_fixes	More logging fixes Migrated previously missed log invocations to source generated logging. Fixed some logging parameters not being PascalCase. Added 2 more diagnostics: - [CA2254: Template should be a static expression](https://learn.microsoft.co...	Pull #508	21 Feb 2026 10:25PM UTC	DemoBytom	coveralls.net	29.32
22203162831	feature/small_fixes	Update Dependabot to observe `main` branch Dependabot was setup to observe `develop` branch. That branch has since been removed and replaced with `main` as the default branch for the repository.	Pull #505	19 Feb 2026 10:46PM UTC	DemoBytom	coveralls.net	29.38
22199895999	feature/small_fixes	Switch to source generated logging Turned on [CA1873](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1873) as Warning Refactored all logging instances to use source generated loggers	Pull #504	19 Feb 2026 09:05PM UTC	DemoBytom	coveralls.net	29.38
22160458527	feature/small_fixes	Merge branch 'main' into feature/small_fixes	push	18 Feb 2026 10:42PM UTC	web-flow	coveralls.net	30.02
22160476800	feature/small_fixes	Fixed `DisposedException` when calling `mainLoopLifetime.Cancel` The `mainLoopLifetime.Cancel()` in `StaThreadService` was called after `TaskCompletionSource.SetResult()`. That task ending was leading to `MainLoopLifetime` being already disposed ...	Pull #503	18 Feb 2026 10:41PM UTC	DemoBytom	coveralls.net	30.02
22160423383	feature/small_fixes	Fixed `DisposedException` when calling `mainLoopLifetime.Cancel` The `mainLoopLifetime.Cancel()` in `StaThreadService` was called after `TaskCompletionSource.SetResult()`. That task ending was leading to `MainLoopLifetime` being already disposed ...	Pull #503	18 Feb 2026 10:41PM UTC	DemoBytom	coveralls.net	30.02
22106801760	feature/small_fixes	Fixes #501 where `IMainLoopLifetime` was resolved from wrong scope `IMainLoopLifetime` was resolved from different scope in `EngineService` than anywhere else within the services. Fixes #501	Pull #502	17 Feb 2026 04:38PM UTC	DemoBytom	coveralls.net	29.99

DemoBytom / DemoEngine
29%
develop: 26%

DemoBytom / DemoEngine 29% develop: 26%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on feature/small_fixes

Recent builds

DemoBytom / DemoEngine
29%
develop: 26%

README BADGES
x

CHANGE BRANCH
x