22419506041
29%
develop: 26%

Ran 27 Feb 2026 07:48PM UTC

Jobs 1

Files 68

Run time 1min

Badge

Embed ▾

Committed 25 Feb 2026 10:52PM UTC coverage: 29.406% (+0.09%) from 29.317%

Build # 22419506041

Build Type

Pull #512

coveralls.net

Committed by

DemoBytom

Commit Message

Async refactor - `StaThreadRequest` and `AsyncServiceScopes`

A warning was reported due to incorrectly disposing types that only implement `IAsyncDisposable`:
```
Demo.Engine Warning: 0 : AUTOFAC: A synchronous Dispose has been attempted, but the tracked object of type 'Demo.Engine.Core.Services.MainLoopService' only implements IAsyncDisposable. This will result in an inefficient blocking dispose. Consider either implementing IDisposable on 'Demo.Engine.Core.Services.MainLoopService' or disposing of the scope/container with DisposeAsync.
```

The solution was to use an `AsyncServiceScope` retreived via `_scopeFactory.CreateAsyncScope()` instead `IServiceScope` from `_scopeFactory.CreateScope()`.
This led to a bigger refactor as scopes were also created within `RenderingSurface` which in turn then required a `IAsyncDisposable` implementation. Changes in `RenderingSurface` required changes in `StaThreadRequests` and so on. Turtles all the way down 🐢🐢🐢
Currently all async methods are properly awaited and don't deadlock. But some `.ConfigureAwaits` might need to be added. This will be evaluated later.

Fixes #511

Pull Request Pull Request #512: Async refactor - `StaThreadRequest` and `AsyncServiceScopes`

Run Details

644 of 2190 relevant lines covered (29.41%)

0.32 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
4	0.0	0.0%	/src/Demo.Engine.Core/Services/LoggingExtensions.cs
5	0.0	0.0%	/src/Demo.Engine.Core/obj/release/net10.0/Microsoft.Extensions.Logging.Generators/Microsoft.Extensions.Logging.Generators.LoggerMessageGenerator/LoggerMessage.g.cs
6	92.94	0.35%	/src/Demo.Engine.Core/Features/StaThread/StaThreadService.cs
70	0.0	0.0%	/src/Demo.Engine.Platform.DirectX12/D3D12RenderingEngine.cs

Jobs

ID	Job ID	Ran	Files	Coverage
1	22419506041.1	27 Feb 2026 07:48PM UTC	133	10.83

DemoBytom / DemoEngine / 22419506041
29%
develop: 26%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 22419506041

DemoBytom / DemoEngine / 22419506041 29% develop: 26%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 22419506041

DemoBytom / DemoEngine / 22419506041
29%
develop: 26%

README BADGES
x