BuildingSync / BuildingSync-website

83%

LAST BUILD ON BRANCH develop

branch: develop

CHANGE BRANCH

x

Reset

Sync Branches

• develop
• Add-BAE-to-tools
• Add-descriptions-to-db-and-ui
• Add-v-change-warning
• BuildingSync-2.5.0-release
• BuildingSync-2.6.0-release
• BuildingSync-2.7.0-release-
• Updated-BEDES-Mapping
• add-integration-test
• alliance-namechange
• analytics
• apr26-updates
• bedes-enum-fix
• bedes-field-sizes
• bedes-fix
• bedes-mapping-bedes-2.5-to-bsync-2.6
• bedes-mapping-bedes-2.5-to-bsync-2.7
• bugfix/header-height
• dependabot/github_actions/actions-deps-6a14be197d
• dependabot/github_actions/actions-deps-76468cb07f
• dependabot/pip/django-2.2.27
• dependabot/pip/django-2.2.28
• dependabot/pip/prod-deps-681b9d981b
• dependabot/pip/prod-deps-f279c47bc2
• dependabot/pip/uwsgi-2.0.22
• django-update
• fix-backup-folders
• fix-bsync-links
• fix-download-examples
• fix-ipynb-link
• fix-link
• fix-paths
• fix-precommit-run
• fix-validator-file-options
• fix-versions-of-examples
• fix/delete-uploaded-files
• fix/notebook-location
• ignore-updating-django
• language-update
• link-tree
• main
• name-update
• precommit
• reference-fix
• relax-bedes-term
• remove-old-prs
• remove-old-selection-refs
• run-precommit
• task/improvements
• task/publication-update
• task/small-fixes
• task/update-ci
• test-backup
• update-changelog
• update-changelog-again
• update-dependabot-config
• update-docker-container
• update-docs-to-2.5
• update-version-and-changelog
• update-website
• updates-for-2.4.0
• upgrade-python-via-alpine
• use-case-diagram
• validator-bug

Build # 37965988507

Build Type

push

github

Committed by web-flow

Commit Message

Ensure uploaded validator files are always deleted (#228)

* Ensure uploaded validator files are always deleted

Uploaded XML/ZIP files were written to a NamedTemporaryFile(delete=False)
and only unlinked on the single-XML success path. The API ZIP path never
removed the upload, and exceptions in any path skipped cleanup, leaving
files in /tmp.

- Add a saved_upload context manager that always deletes the temp file
- Use it in the API (XML and ZIP) and the web validator form
- Extract API ZIP contents in a TemporaryDirectory context manager
- Add a privacy notice to the validator page
- Add tests asserting no files remain after XML, ZIP, and error cases

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* privacy text

* added debug statement to verify file is deleted after validation

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Coverage Stats

67 of 79 new or added lines in 2 files covered. (84.81%)

1958 of 2356 relevant lines covered (83.11%)

0.83 hits per line