BuildingSync / BuildingSync-website / 37965988507

83%

push

github

Ensure uploaded validator files are always deleted (#228)

* Ensure uploaded validator files are always deleted

Uploaded XML/ZIP files were written to a NamedTemporaryFile(delete=False)
and only unlinked on the single-XML success path. The API ZIP path never
removed the upload, and exceptions in any path skipped cleanup, leaving
files in /tmp.

- Add a saved_upload context manager that always deletes the temp file
- Use it in the API (XML and ZIP) and the web validator form
- Extract API ZIP contents in a TemporaryDirectory context manager
- Add a privacy notice to the validator page
- Add tests asserting no files remain after XML, ZIP, and error cases

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* privacy text

* added debug statement to verify file is deleted after validation

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

67 of 79 new or added lines in 2 files covered. (84.81%)

1958 of 2356 relevant lines covered (83.11%)

0.83 hits per line